[AutoRelease] t2-containerservice-2025-06-04-99453(can only be merged by SDK owner) #41416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the Containerservice SDK to version 37.0.0, updates supported API versions and model imports, and refines the return types of listing operations to use paged iterators.
- Version bump to 37.0.0 across client and version files
- Switched
list/list_by_resource_groupreturn types fromIterable/AsyncIterabletoItemPaged/AsyncItemPaged - Added new
ManagedNamespacesOperations, updated model import slices, and regenerated metadata
Reviewed Changes
Copilot reviewed 260 out of 260 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| operations/*/_managed_clusters_operations.py & _agent_pools_operations.py | Added -> ItemPaged[...] on list methods but missing import |
| aio/operations/_operations.py | Switched to -> AsyncItemPaged[...] without importing type |
| aio/_container_service_client.py & _container_service_client.py | Bumped DEFAULT_API_VERSION, updated profile to include new previews |
| models.py | Replaced v2025_02_02_preview & v2025_03_01 imports with v2025_03_02_preview & v2025_04_01 |
| *_version.py (all) | Version field updated to "37.0.0" |
| MANIFEST.in | Removed inclusion of _meta.json but not including the new _metadata.json |
| CHANGELOG.md | Added 37.0.0 release notes with breaking changes |
Comments suppressed due to low confidence (3)
sdk/containerservice/azure-mgmt-containerservice/MANIFEST.in:1
- The new
_metadata.jsonfile is not included in the package manifest. Consider addinginclude _metadata.jsonso it’s packaged.
recursive-include tests *.py *.json
sdk/containerservice/azure-mgmt-containerservice/azure/mgmt/containerservice/v2020_03_01/operations/_managed_clusters_operations.py:11
- The methods now return ItemPaged, but ItemPaged is not imported. Please add
from azure.core.paging import ItemPaged.
from typing import Any, Callable, Dict, IO, Iterator, Optional, TypeVar, Union, cast, overload
sdk/containerservice/azure-mgmt-containerservice/azure/mgmt/containerservice/v2020_03_01/aio/operations/_operations.py:9
- The
listmethod return type is now AsyncItemPaged but AsyncItemPaged is not imported. Please addfrom azure.core.async_paging import AsyncItemPagedor the correct AsyncItemPaged import.
from typing import Any, Callable, Dict, Optional, TypeVar
ChenxiJiang333
approved these changes
Jun 11, 2025
msyyc
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6272
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=982
BuildTargetingString
azure-mgmt-containerservice
Skip.CreateApiReview