Also name the BUILD file in external repository roots BUILD.bazel (bazel-contrib#457)

person142 · web-flow · commit 04c6d7fb1361 · 2021-04-18T16:34:25.000-07:00
* Also name the BUILD file in external repository roots BUILD.bazel

* Don't put empty BUILD.bazel into package-specific external repos
diff --git a/python/pip_install/pip_repository.bzl b/python/pip_install/pip_repository.bzl
@@ -12,7 +12,6 @@ def _construct_pypath(rctx):
         rctx: Handle to the repository_context.
     Returns: String of the PYTHONPATH.
     """
-    rctx.file("BUILD", "")
 
     # Get the root directory of these rules
     rules_root = rctx.path(Label("//:BUILD")).dirname
@@ -64,6 +63,9 @@ def _pip_repository_impl(rctx):
     if rctx.attr.incremental and not rctx.attr.requirements_lock:
         fail("Incremental mode requires a requirements_lock attribute be specified.")
 
+    # We need a BUILD file to load the generated requirements.bzl
+    rctx.file("BUILD.bazel", "")
+
     pypath = _construct_pypath(rctx)
 
     if rctx.attr.incremental:
