8000 HttpResponseStatus does not need AsyncHttpClientConfig in constructor · Issue #1340 · AsyncHttpClient/async-http-client · GitHub
[go: up one dir, main page]

Skip to content
HttpResponseStatus does not need AsyncHttpClientConfig in constructor #1340
Closed
@wsargent

Description

@wsargent

Looking at the HttpResponseStatus, it's an abstract class that requires a config passed in the constructor:

https://github.com/AsyncHttpClient/async-http-client/blob/master/client/src/main/java/org/asynchttpclient/HttpResponseStatus.java#L29

However, the two implementing classes, Netty and HttpStatusWrapper do not make use of Config and it's not exposed in the API.

        public HttpStatusWrapper(HttpResponseStatus wrapper, String statusText, int statusCode) {
            super(wrapper.getUri(), (AsyncHttpClientConfig)null);
            this.wrapped = wrapper;
            this.statusText = statusText;
            this.statusCode = statusCode;
        }

It'd be nice if the config was not required in the abstract class constructor. :-)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0