events: fix propagation - should propagate when there are no callbacks on current instance

yyx990803 · yyx990803 · commit b8b87f71af12 · 2015-10-09T22:28:47.000-04:00
diff --git a/src/api/events.js b/src/api/events.js
@@ -87,8 +87,8 @@ exports.$off = function (event, fn) {
  */
 
 exports.$emit = function (event) {
-  this._shouldPropagate = false
   var cbs = this._events[event]
+  this._shouldPropagate = !cbs
   if (cbs) {
     cbs = cbs.length > 1
       ? _.toArray(cbs)
diff --git a/test/unit/specs/api/events_spec.js b/test/unit/specs/api/events_spec.js
@@ -144,12 +144,13 @@ describe('Events API', function () {
   it('$dispatch with propagation', function () {
     var child = vm.$addChild()
     var child2 = child.$addChild()
+    var child3 = child2.$addChild()
     child.$on('test', function () {
       spy()
       return true
     })
     vm.$on('test', spy)
-    child2.$dispatch('test')
+    child3.$dispatch('test')
     expect(spy.calls.count()).toBe(2)
   })
 
