v-on: support modifiers without expression (close vuejs#1451)

yyx990803 · yyx990803 · commit 91d6eeb02363 · 2015-10-22T16:41:48.000-04:00
diff --git a/src/directive.js b/src/directive.js
@@ -106,7 +106,7 @@ Directive.prototype._bind = function () {
   if (this._literal) {
     this.update && this.update(this.expression)
   } else if (
-    this._watcherExp &&
+    (this._watcherExp || this.modifiers) &&
     (this.update || this.twoWay) &&
     (!this.isLiteral || this._isDynamicLiteral) &&
     !this._checkStatement()
diff --git a/src/directives/on.js b/src/directives/on.js
@@ -74,6 +74,12 @@ module.exports = {
   },
 
   update: function (handler) {
+    // stub a noop for v-on with no value,
+    // e.g. @mousedown.prevent
+    if (!this._descriptor.raw) {
+      handler = function () {}
+    }
+
     if (typeof handler !== 'function') {
       process.env.NODE_ENV !== 'production' && _.warn(
         'v-on:' + this.arg + '="' +
diff --git a/src/parsers/directive-new.js b/src/parsers/directive-new.js
@@ -81,7 +81,7 @@ exports.parse = function (s) {
   inSingle = inDouble = false
   curly = square = paren = 0
   lastFilterIndex = 0
-  dir = {}
+  dir = { raw: s }
 
   for (i = 0, l = str.length; i < l; i++) {
     c = str.charCodeAt(i)
diff --git a/test/unit/specs/directives/on_spec.js b/test/unit/specs/directives/on_spec.js
@@ -126,6 +126,16 @@ if (_.inBrowser) {
       expect(prevented).toBe(true)
     })
 
+    it('prevent modifier with no value', function () {
+      new Vue({
+        el: el,
+        template: '<a href="#123" @click.prevent>'
+      })
+      var hash = window.location.hash
+      trigger(el.firstChild, 'click')
+      expect(window.location.hash).toBe(hash)
+    })
+
     it('multiple modifiers working together', function () {
       var outer = jasmine.createSpy('outer')
       var prevented
