ci: Quality

pawamoy · pawamoy · commit 93ccaaa01e57 · 2023-07-02T18:26:10.000+02:00
diff --git a/src/mkdocstrings_handlers/python/handler.py b/src/mkdocstrings_handlers/python/handler.py
@@ -10,7 +10,7 @@
 import sys
 from collections import ChainMap
 from contextlib import suppress
-from typing import TYPE_CHECKING, Any, BinaryIO, Iterator, Mapping
+from typing import TYPE_CHECKING, Any, BinaryIO, ClassVar, Iterator, Mapping
 
 from griffe.collections import LinesCollection, ModulesCollection
 from griffe.docstrings.parsers import Parser
@@ -71,8 +71,8 @@ class PythonHandler(BaseHandler):
     domain: str = "py"  # to match Sphinx's default domain
     enable_inventory: bool = True
     fallback_theme = "material"
-    fallback_config: dict = {"fallback": True}
-    default_config: dict = {
+    fallback_config: ClassVar[dict] = {"fallback": True}  # type: ignore[misc]
+    default_config: ClassVar[dict] = {
         "docstring_style": "google",
         "docstring_options": {},
         "show_root_heading": False,
diff --git a/src/mkdocstrings_handlers/python/rendering.py b/src/mkdocstrings_handlers/python/rendering.py
@@ -103,8 +103,7 @@ def do_format_signature(
     template = env.get_template("signature.html")
     signature = template.render(context.parent, function=function)
     signature = _format_signature(callable_path, signature, line_length)
-    signature = str(env.filters["highlight"](signature, language="python", inline=False))
-    return signature
+    return str(env.filters["highlight"](signature, language="python", inline=False))
 
 
 def do_order_members(
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -41,7 +41,7 @@ def fixture_mkdocs_conf(request: pytest.FixtureRequest, tmp_path: Path) -> Itera
         **getattr(request, "param", {}),
     }
     # Re-create it manually as a workaround for https://github.com/mkdocs/mkdocs/issues/2289
-    mdx_configs: dict[str, Any] = dict(ChainMap(*conf_dict.get("markdown_extensions", [])))  # type: ignore[arg-type]
+    mdx_configs: dict[str, Any] = dict(ChainMap(*conf_dict.get("markdown_extensions", [])))
 
     conf.load_dict(conf_dict)
     assert conf.validate() == ([], [])

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ def fixture_mkdocs_conf(request: pytest.FixtureRequest, tmp_path: Path) -> Itera`
`41`	`41`	`**getattr(request, "param", {}),`
`42`	`42`	`}`
`43`	`43`	`# Re-create it manually as a workaround for https://github.com/mkdocs/mkdocs/issues/2289`
`44`		`- mdx_configs: dict[str, Any] = dict(ChainMap(*conf_dict.get("markdown_extensions", []))) # type: ignore[arg-type]`
	`44`	`+ mdx_configs: dict[str, Any] = dict(ChainMap(*conf_dict.get("markdown_extensions", [])))`
`45`	`45`
`46`	`46`	`conf.load_dict(conf_dict)`
`47`	`47`	`assert conf.validate() == ([], [])`