Fix issues with login vs id

Christophe LECOINTE · EricDales · commit ad4be9a2940e · 2016-11-24T12:34:31.000+01:00
All lights are green, I accept this change
diff --git a/github3/users.py b/github3/users.py
@@ -391,7 +391,7 @@ def rename(self, login):
         :param str login: (required), new name of the user
         :returns: bool
         """
-        url = self._build_url('admin', 'users', self.id)
+        url = self._build_url('admin', 'users', self.login)
         payload = {'login': login}
         resp = self._boolean(self._patch(url, data=payload), 202, 403)
         return resp
@@ -407,7 +407,7 @@ def impersonate(self, scopes=None):
             i.e., 'gist', 'user'
         :returns: :class:`Authorization <Authorization>`
         """
-        url = self._build_url('admin', 'users', self.id, 'authorizations')
+        url = self._build_url('admin', 'users', self.login, 'authorizations')
         data = {}
 
         if scopes:
@@ -425,7 +425,7 @@ def revoke_impersonation(self):
 
         :returns: bool -- True if successful, False otherwise
         """
-        url = self._build_url('admin', 'users', self.id, 'authorizations')
+        url = self._build_url('admin', 'users', self.login, 'authorizations')
 
         return self._boolean(self._delete(url), 204, 403)
 
@@ -494,5 +494,5 @@ def delete(self):
 
         :returns: bool -- True if successful, False otherwise
         """
-        url = self._build_url('admin', 'users', self.id)
+        url = self._build_url('admin', 'users', self.login)
         return self._boolean(self._delete(url), 204, 403)
diff --git a/tests/unit/test_github_enterprise.py b/tests/unit/test_github_enterprise.py
@@ -1,6 +1,5 @@
-from github3.github import GitHubEnterprise
 import github3
-
+from github3.github import GitHubEnterprise
 from .helper import UnitHelper, create_example_data_helper
 
 get_example_user = create_example_data_helper('user_example')
@@ -52,7 +51,8 @@ def url_for_user(self, path=''):
         return self.base_url + 'users/' + example_data['login'] + path
 
     def url_for_admin(self, path=''):
-        return self.base_url + 'admin/users/' + str(example_data['id']) + path
+        return self.base_url + 'admin/users/' + str(example_data['login']) \
+               + path
 
     def test_delete_user(self):
         """Show that an admin can ask for user deletion."""
