Merge pull request postgres#12 from CartoDB/REL_10_CARTO_inline_functions

Rafa de la Torre · web-flow · commit 2f29cfc5e6d8 · 2017-12-05T13:20:59.000+01:00
Allow SQL functions to inline in the presence of costly parameter functions
diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
@@ -4545,7 +4545,7 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
 		else if (usecounts[i] != 1)
 		{
 			/* Param used multiple times: uncool if expensive or volatile */
-			QualCost	eval_cost;
+			// QualCost	eval_cost;
 
 			/*
 			 * We define "expensive" as "contains any subplan or more than 10
@@ -4555,10 +4555,10 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
 			 */
 			if (contain_subplans(param))
 				goto fail;
-			cost_qual_eval(&eval_cost, list_make1(param), NULL);
-			if (eval_cost.startup + eval_cost.per_tuple >
-				10 * cpu_operator_cost)
-				goto fail;
+			// cost_qual_eval(&eval_cost, list_make1(param), NULL);
+			// if (eval_cost.startup + eval_cost.per_tuple >
+			// 	10 * cpu_operator_cost)
+			// 	goto fail;
 
 			/*
 			 * Check volatility last since this is more expensive than the
