Compile fields in oneof as optional

AdrienVannson · AdrienVannson · commit 5e65d4f52fb4 · 2024-11-12T15:28:26.000+01:00
diff --git a/src/betterproto/plugin/models.py b/src/betterproto/plugin/models.py
@@ -569,6 +569,10 @@ def annotation(self) -> str:
 
 @dataclass
 class OneOfFieldCompiler(FieldCompiler):
+    @property
+    def optional(self) -> bool:
+        return True
+
     @property
     def betterproto_field_args(self) -> List[str]:
         args = super().betterproto_field_args
@@ -579,13 +583,6 @@ def betterproto_field_args(self) -> List[str]:
 
 @dataclass
 class PydanticOneOfFieldCompiler(OneOfFieldCompiler):
-    @property
-    def optional(self) -> bool:
-        # Force the optional to be True. This will allow the pydantic dataclass
-        # to validate the object correctly by allowing the field to be let empty.
-        # We add a pydantic validator later to ensure exactly one field is defined.
-        return True
-
     @property
     def pydantic_imports(self) -> Set[str]:
         return {"model_validator"}
