Completed excercise 12

10h30 · 10h30 · commit 22a6289b629e · 2025-02-26T11:16:51.000+09:00
diff --git a/12_findTheOldest/findTheOldest.js b/12_findTheOldest/findTheOldest.js
@@ -1,5 +1,30 @@
-const findTheOldest = function() {
+const findTheOldest = function(people) {
+    console.log(people)
+    const sortByAge = people.sort((a,b) => {
+       
+        if (!a.yearOfDeath) {
+            let currentYear = new Date().getFullYear();            console.log(currentYear)
+            ageOfa = currentYear - a.yearOfBirth
+        }
+        else {
+            ageOfa = a.yearOfDeath - a.yearOfBirth
+        }
+        console.log(a.name + ": " + ageOfa)
 
+        if (!b.yearOfDeath) {
+            let currentYear = new Date().getFullYear();
+            ageOfb = currentYear - b.yearOfBirth
+        }
+        else {
+            ageOfb = b.yearOfDeath - b.yearOfBirth
+        }
+        console.log(b.name + ": " + ageOfb)
+        
+        return ageOfa < ageOfb ? 1 : -1
+    })
+    const oldest = sortByAge[0]
+    console.log(oldest);
+    return oldest;
 };
 
 // Do not edit below this line
diff --git a/12_findTheOldest/findTheOldest.spec.js b/12_findTheOldest/findTheOldest.spec.js
@@ -21,7 +21,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
+  test('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
     const people = [
       {
         name: "Carly",
@@ -40,7 +40,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
+  test('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
     const people = [
       {
         name: "Carly",

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ describe('findTheOldest', () => {`
`21`	`21`	`]`
`22`	`22`	`expect(findTheOldest(people).name).toBe('Ray');`
`23`	`23`	`});`
`24`		`- test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {`
	`24`	`+ test('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {`
`25`	`25`	`const people = [`
`26`	`26`	`{`
`27`	`27`	`name: "Carly",`
`@@ -40,7 +40,7 @@ describe('findTheOldest', () => {`
`40`	`40`	`]`
`41`	`41`	`expect(findTheOldest(people).name).toBe('Ray');`
`42`	`42`	`});`
`43`		`- test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {`
	`43`	`+ test('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {`
`44`	`44`	`const people = [`
`45`	`45`	`{`
`46`	`46`	`name: "Carly",`