8000 feat(examples): with-grafbase by notrab · Pull Request #42898 · vercel/next.js · GitHub < 8000 meta name="fetch-nonce" content="v2:3e3dd755-67dc-930e-4631-8a09c88203b4">
[go: up one dir, main page]
Skip to content

Comments

feat(examples): with-grafbase#42898

Merged
balazsorban44 merged 6 commits intovercel:canaryfrom
grafbase:gb-2460-pr-with-grafbase-example-to-nextjs
Nov 15, 2022
Merged

feat(examples): with-grafbase#42898
balazsorban44 merged 6 commits intovercel:canaryfrom
grafbase:gb-2460-pr-with-grafbase-example-to-nextjs

Conversation

@notrab
Copy link
Contributor
@notrab notrab commented Nov 14, 2022 •
edited
Loading

This PR adds the with-grafbase example. with- prefix can be removed to follow guidelines but unsure if this is outdated since all other examples include this for similar services.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Todo

  • Vercel deploy button
  • Grafbase deploy button (with template schema)

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 14, 2022
@notrab notrab changed the title initial commit feat(examples): with-grafbase Nov 14, 2022
balazsorban44
balazsorban44 reviewed Nov 14, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed Nov 14, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed Nov 14, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed Nov 14, 2022
View reviewed changes
balazsorban44
balazsorban44 reviewed Nov 14, 2022
View reviewed changes
@notrab
Copy link
Contributor Author
notrab commented Nov 15, 2022

Thanks for reviewing @balazsorban44. I didn't quite finish pushing changes yesterday hence the draft PR so most of your comments should be resolved in that.

@notrab notrab marked this pull request as ready for review November 15, 2022 10:17
@notrab notrab requested a review from balazsorban44 November 15, 2022 10:17
balazsorban44
balazsorban44 requested changes Nov 15, 2022
View reviewed changes
Copy link
Member
@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that linting passes? https://github.com/vercel/next.js/actions/runs/3469499938/jobs/5796602833

you can run pnpm prettier --write examples/with-grafbase and commit the changed files

balazsorban44
balazsorban44 reviewed Nov 15, 2022
View reviewed changes
@notrab notrab force-pushed the gb-2460-pr-with-grafbase-example-to-nextjs branch from 7a6619f to 650b4d7 Compare November 15, 2022 12:21
@notrab notrab requested a review from balazsorban44 November 15, 2022 12:22
@notrab
Copy link
Contributor Author
notrab commented Nov 15, 2022

@balazsorban44 all done 🙌🏻

@balazsorban44
Copy link
Member
balazsorban44 commented Nov 15, 2022

Thanks!

@balazsorban44 balazsorban44 merged commit fbf6bfa into vercel:canary Nov 15, 2022
@notrab notrab deleted the gb-2460-pr-with-grafbase-example-to-nextjs branch November 15, 2022 19:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
923A
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notrab @balazsorban44 @ijjk
0