Add GHRepository#hasPermission() #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1433 +/- ##
============================================
+ Coverage 78.62% 78.65% +0.02%
- Complexity 2090 2097 +7
============================================
Files 201 201
Lines 6381 6389 +8
Branches 357 359 +2
============================================
+ Hits 5017 5025 +8
Misses 1157 1157
Partials 207 207
Continue to review full report at Codecov.
|
|
BTW, if you can include it in 1.304, that would be awesome! |
bitwiseman
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bitwiseman this is a proposal to add a
GHRepository#hasPermission(user, permission)method.The rationale of it is that most often than not you want to check that someone has at least a given level and not a specific permission.
The current API makes it a bit cumbersome to do it.
The added test explains it all.