8000 Add `Licensed` To Help Verify Prod Licenses by thboop · Pull Request #180 · actions/setup-node · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@thboop
Copy link
Contributor
@thboop thboop commented Aug 12, 2020

GitHub has a tool called licensed which helps us to verify that the node modules we are using are appropriately licensed for what we are using them for. It also helps to verify that the license a node module claims to be under matches the license it.

If you were previously checking in a license in the dist file, this can replace that flow.

This PR adds:

  • A workflow to check licenses on pull requests and pushes to the main branch
  • A licensed.yml file used to configure licensed
  • A number of files into the .licenses directory which contain our dependencies and their appropriate licenses

How does this impact me?

  • You may need to locally install licensed and run licensed cache to update the dependency cache if you install a new production dependency.
    • If licensed cache is unable to determine the dependency, you may need to modify the cache file yourself to put the correct license.
  • You should still verify the dependency, licensed in a tool to help, but is not a substitute for human review of dependencies
  • Currently, this PR only targets production dependencies, dev dependencies are not included.

@thboop thboop marked this pull request as ready for review August 26, 2020 15:30
@bryanmacfarlane bryanmacfarlane self-assigned this Sep 10, 2020
@thboop thboop merged commit c211e95 into actions:main Sep 10, 2020
deining pushed a commit to deining/setup-node that referenced this pull request 7D67 Nov 9, 2023
* fix: switch to string-argv for git args parsing

* chore: fix debug messages for matchGitArgs

* docs: add paragraph about git args parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0