blender/blender
blender/blender
185
593
Fork 918
Code Issues 6.3k Pull Requests 1.1k Projects 22 Wiki Activity

Regression: Crash when adding color attribute in edit mode #98673

New Issue
Closed
opened 2022-06-08 17:00:37 +02:00 by Dvorakir · 16 comments
Dvorakir commented 2022-06-08 17:00:37 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65

Blender Version
Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: e05e1e3691
Worked: 3.1

Caused by 3d5f5c2d9a

Short description of error
Adding a color attribute to a mesh from the Color Attribute panel causes a crash if the object is in edit mode.
A crash does not occur if a color type attribute is added manually from the Attributes panel

Exact steps for others to reproduce the error
Based on the default startup file:

  1. enter edit mode on the cube
  2. try adding a color attribute
  3. crash

blender_2022-06-08_16-58-25.mp4

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65 **Blender Version** Broken: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22, hash: `e05e1e3691` Worked: 3.1 Caused by 3d5f5c2d9a **Short description of error** Adding a color attribute to a mesh from the Color Attribute panel causes a crash if the object is in edit mode. A crash does not occur if a color type attribute is added manually from the Attributes panel **Exact steps for others to reproduce the error** Based on the default startup file: 1. enter edit mode on the cube 2. try adding a color attribute 3. crash [blender_2022-06-08_16-58-25.mp4](https://archive.blender.org/developer/F13138594/blender_2022-06-08_16-58-25.mp4)
Dvorakir commented 2022-06-08 17:00:37 +02:00
Author
Copy Link

Added subscriber: @Dvorakir

Added subscriber: @Dvorakir
blender-admin commented 2022-06-08 17:00:37 +02:00
Copy Link

#99160 was marked as duplicate of this issue

#99160 was marked as duplicate of this issue
blender-admin commented 2022-06-08 17:00:37 +02:00
Copy Link

#98819 was marked as duplicate of this issue

#98819 was marked as duplicate of this issue
Richard Antalik commented 2022-06-08 20:18:49 +02:00
Member
Copy Link

Added subscriber: @iss

Added subscriber: @iss
Richard Antalik commented 2022-06-08 20:18:49 +02:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Richard Antalik commented 2022-06-08 20:18:49 +02:00
Member
Copy Link

Can confirm, in debug build this triggers assert BLI_assert(me->edit_mesh == nullptr);

 	blender.exe!_BLI_assert_abort() Řádek 47	C
>	blender.exe!ED_mesh_color_ensure(Mesh * me, const char * name) Řádek 430	C++

 	blender.exe!vertex_color_set<blender::ColorSceneLinear4f<0>,blender::color::FloatTraits,0>(Object * ob, blender::ColorSceneLinear4f<0> paintcol_in, blender::ColorSceneLinear4f<0> * color_layer) Řádek 4104	C++
 	blender.exe!paint_object_attributes_active_color_fill_ex(Object * ob, blender::ColorSceneLinear4f<0> fill_color, bool only_selected) Řádek 4172	C++
 	blender.exe!BKE_object_attributes_active_color_fill(Object * ob, const float * fill_color, bool only_selected) Řádek 4200	C++
 	blender.exe!blender::ed::geometry::geometry_color_attribute_add_exec(bContext * C, wmOperator * op) Řádek 241	C++
 	blender.exe!wm_operator_exec(bContext * C, wmOperator * op, const bool repeat, const bool store) Řádek 1099	C++
 	blender.exe!WM_operator_call_ex(bContext * C, wmOperator * op, bool store) Řádek 1147	C++
 	blender.exe!dialog_exec_cb(bContext * C, void * arg1, void * arg2) Řádek 1427	C
 	blender.exe!ui_apply_but_funcs_after(bContext * C) Řádek 1038	C
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Řádek 11522	C
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Řádek 732	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Řádek 3166	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Řádek 3285	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Řádek 3878	C++
 	blender.exe!WM_main(bContext * C) Řádek 626	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Řádek 551	C
 	[Externí kód]
Can confirm, in debug build this triggers assert `BLI_assert(me->edit_mesh == nullptr);` ``` blender.exe!_BLI_assert_abort() Řádek 47 C > blender.exe!ED_mesh_color_ensure(Mesh * me, const char * name) Řádek 430 C++ blender.exe!vertex_color_set<blender::ColorSceneLinear4f<0>,blender::color::FloatTraits,0>(Object * ob, blender::ColorSceneLinear4f<0> paintcol_in, blender::ColorSceneLinear4f<0> * color_layer) Řádek 4104 C++ blender.exe!paint_object_attributes_active_color_fill_ex(Object * ob, blender::ColorSceneLinear4f<0> fill_color, bool only_selected) Řádek 4172 C++ blender.exe!BKE_object_attributes_active_color_fill(Object * ob, const float * fill_color, bool only_selected) Řádek 4200 C++ blender.exe!blender::ed::geometry::geometry_color_attribute_add_exec(bContext * C, wmOperator * op) Řádek 241 C++ blender.exe!wm_operator_exec(bContext * C, wmOperator * op, const bool repeat, const bool store) Řádek 1099 C++ blender.exe!WM_operator_call_ex(bContext * C, wmOperator * op, bool store) Řádek 1147 C++ blender.exe!dialog_exec_cb(bContext * C, void * arg1, void * arg2) Řádek 1427 C blender.exe!ui_apply_but_funcs_after(bContext * C) Řádek 1038 C blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Řádek 11522 C blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Řádek 732 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Řádek 3166 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Řádek 3285 C++ blender.exe!wm_event_do_handlers(bContext * C) Řádek 3878 C++ blender.exe!WM_main(bContext * C) Řádek 626 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Řádek 551 C [Externí kód] ```
Philipp Oeser commented 2022-06-09 09:12:27 +02:00
Member
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2022-06-09 09:12:27 +02:00
Philipp Oeser commented 2022-06-09 09:12:27 +02:00
Member
Copy Link

Will check

Will check
Philipp Oeser changed title from Crash when adding color attribute in edit mode to Regression: Crash when adding color attribute in edit mode 2022-06-09 10:11:24 +02:00
Jesse Yurkovich commented 2022-06-12 22:12:51 +02:00
Member
Copy Link

Added subscriber: @beta-tester

Added subscriber: @beta-tester
Philipp Oeser removed their assignment 2022-06-23 18:31:12 +02:00
Philipp Oeser commented 2022-06-23 18:31:12 +02:00
Member
Copy Link

I claimed this because I thought I had the fix already, turns out there might be a better way to do it.
Cannot tell if I can get a solution for 3.2.1, so will step down if others are quicker...

I claimed this because I thought I had the fix already, turns out there might be a better way to do it. Cannot tell if I can get a solution for 3.2.1, so will step down if others are quicker...
Evan Wilson commented 2022-06-25 07:09:22 +02:00
Member
Copy Link

Added subscriber: @Shady.Hamza

Added subscriber: @Shady.Hamza
blender-admin commented 2022-06-27 02:11:03 +02:00
Copy Link

This issue was referenced by 30273b86c7

This issue was referenced by 30273b86c7ffc79746d21952970fec25db523c1c
Joseph Eagar commented 2022-06-27 02:11:53 +02:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Joseph Eagar self-assigned this 2022-06-27 02:11:53 +02:00
Pratik Borhade commented 2022-06-27 05:16:56 +02:00
Member
Copy Link

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Pratik Borhade commented 2022-06-27 05:16:56 +02:00
Member
Copy Link

Mentioned the task and commit in corrective release list. Feel free to remove if fix is not appropriate for backporting

Mentioned the task and commit in corrective release list. Feel free to remove if fix is not appropriate for backporting
blender-admin commented 2022-07-04 16:06:13 +02:00
Copy Link

This issue was referenced by 4b7eaa709f

This issue was referenced by 4b7eaa709f73b43ca6b141be59f9c9b1e0950d8f
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Interest
Modeling
Interest
Sculpt, Paint & Texture
Module
Sculpt, Paint & Texture
Severity
High
Status
Resolved
Type
Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu BassamKurdali bassam kurdali gfxcoder jon denning
No Assignees Joseph Eagar
8 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#98673
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?