-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicting documentation for curl_easy_getinfo
#846
Comments
Agreed. It takes a You up to providing a patch? |
I can send a PR for the docs and updating the example. There is much magic in the |
I poked around at it earlier today and while I can certainly see what changes that need to get done, the entire typecheck logic doesn't really seem to work for me at all at the moment (I tried gcc 5.3.1 as as well as 4.7) so I'm a bit puzzled. I haven't figured out why yet. Applying the patch below fixes the example but causes no warning for me with an unmodified typecheck-gcc.h file. diff --git a/docs/examples/certinfo.c b/docs/examples/certinfo.c
index de2e310..92bf588 100644
--- a/docs/examples/certinfo.c
+++ b/docs/examples/certinfo.c
@@ -3,11 +3,11 @@
* Project ___| | | | _ \| |
* / __| | | | |_) | |
* | (__| |_| | _ <| |___
* \___|\___/|_| \_\_____|
*
- * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.
+ * Copyright (C) 1998 - 2016, Daniel Stenberg, <daniel@haxx.se>, et al.
*
* This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms
* are also available at https://curl.haxx.se/docs/copyright.html.
*
@@ -54,28 +54,23 @@ int main(void)
curl_easy_setopt(curl, CURLOPT_CERTINFO, 1L);
res = curl_easy_perform(curl);
if(!res) {
- union {
- struct curl_slist *to_info;
- struct curl_certinfo *to_certinfo;
- } ptr;
+ struct curl_certinfo *certinfo;
- ptr.to_info = NULL;
+ res = curl_easy_getinfo(curl, CURLINFO_CERTINFO, &certinfo);
- res = curl_easy_getinfo(curl, CURLINFO_CERTINFO, &ptr.to_info);
-
- if(!res && ptr.to_info) {
+ if(!res && certinfo) {
int i;
- printf("%d certs!\n", ptr.to_certinfo->num_of_certs);
+ printf("%d certs!\n", certinfo->num_of_certs);
- for(i = 0; i < ptr.to_certinfo->num_of_certs; i++) {
+ for(i = 0; i < certinfo->num_of_certs; i++) {
struct curl_slist *slist;
- for(slist = ptr.to_certinfo->certinfo[i]; slist; slist = slist->next)
+ for(slist = certinfo->certinfo[i]; slist; slist = slist->next)
printf("%s\n", slist->data);
}
}
|
Yeah, I was running into the same problem. I don't see these warning on any of my machines, only when running on gcc on travis. I wasn't able to dig in deeply enough to know what's different about their setup than mine. |
... and update the certinfo.c example accordingly. Fixes #846
... and update the certinfo.c example accordingly. Fixes #846
... and update the certinfo.c example accordingly. Fixes #846
Old version: 7.50.1 / f2cb3a01192d36395d16acec6cdb93446ca6fd45 New version: 7.54.1 / 54b636f14546d3fde9f9c67c3b32701d78563161 Plus 71a55534fa61b80373271a13de4473d4660364e2 which is needed to build 7.54.1 with boringssl rather than openssl. Bug: http://b/34808840 Test: builds, boots, `vendor/google/tools/fake-ota on streaming` works Change-Id: I0ed0973477c3d118cc31a5bd5a006dede40decb4 Note: This patch includes the following squashed commits from upstream: commit 71a55534fa61b80373271a13de4473d4660364e2 Author: Adam Langley <agl@google.com> Date: Wed Dec 7 12:18:21 2016 -0800 openssl: don't use OpenSSL's ERR_PACK. ERR_PACK is an internal detail of OpenSSL. Also, when using it, a function name must be specified which is overly specific: the test will break whenever OpenSSL internally change things so that a different function creates the error. Closes #1157 commit 54b636f14546d3fde9f9c67c3b32701d78563161 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Jun 13 09:44:50 2017 +0200 release: 7.54.1 commit 49ff9390344930cdc5a6df57b68297c98f78b728 Author: Dan Fandrich <dan@coneharvesters.com> Date: Tue Jun 13 22:03:35 2017 +0200 mk-lib1521.pl: updated to match the test changes in 916ec30a commit 9f54ad8f15172d52cc0df9de8b65887c13a54a90 Author: Stuart Henderson <stu@spacehopper.org> Date: Tue Jun 13 12:06:03 2017 +0200 libressl: OCSP and intermediate certs workaround no longer needed lib/vtls/openssl.c has a workaround for a bug with OCSP responses signed by intermediate certs, this was fixed in LibreSSL in https://github.com/libressl-portable/openbsd/commit/912c64f68f7ac4f225b7d1fdc8fbd43168912ba0 Bug: https://curl.haxx.se/mail/lib-2017-06/0038.html commit 5d7952f52e410e1d4a8ff1965e5cc6fc1bde86aa Author: Daniel Stenberg <daniel@haxx.se> Date: Wed Jun 7 00:21:04 2017 +0200 url: fix buffer overwrite with file protocol (CVE-2017-9502) Bug: https://github.com/curl/curl/issues/1540 Advisory: https://curl.haxx.se/docs/adv_20170614.html Assisted-by: Ray Satiro Reported-by: Marcel Raad commit 5fa028e508056e3569beb5698e3f52e45fea94da Author: Daniel Stenberg <daniel@haxx.se> Date: Sat Jun 10 14:35:07 2017 +0200 urlglob: fix division by zero The multiply() function that is used to avoid integer overflows, was itself reason for a possible division by zero error when passed a specially formatted glob. Reported-by: GwanYeong Kim commit f6dff827d321933a21cb7a697d3007c2ed90217b Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 12 08:42:11 2017 +0200 configure: update the copyright year in the output commit ab1f4eb011d46dc9154c4568e88824acad94b6cb Author: ygrek <ygrek@autistici.org> Date: Sun Jun 11 12:59:18 2017 -0700 BINDINGS: update SP-Forth and OCaml urls commit e8fecf2614b479d2448c61159b4a7dadf4cf7df9 Author: Michael Kaufmann <mail@michael-kaufmann.ch> Date: Tue Jun 6 22:15:17 2017 +0200 FindWin32CACert: Use a temporary buffer on the stack Don't malloc() the temporary buffer, and use the correct type: SearchPath() works with TCHAR, but SearchPathA() works with char. Set the buffer size to MAX_PATH, because the terminating null byte is already included in MAX_PATH. Reviewed-by: Daniel Stenberg Reviewed-by: Marcel Raad Closes #1548 commit 916ec30a92a6a497a89172533830f1593591e875 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun Jun 11 11:49:31 2017 +0200 test1521: fixed OOM handling commit 4024a0b93b36adc1fb4929fd1a91a9f05637d228 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 9 15:58:51 2017 +0200 RELEASE-PROCEDURE: updated future release dates commit 15b7b857590fb49689caf04e4e0109af6c4d3dab Author: Paul Harris <paulharris@computer.org> Date: Fri Jun 9 10:30:39 2017 +0800 gitignore: ignore all vim swap files Closes #1561 commit b94a2cdfe641a9094a2352f3f38b02ead3ffe8d5 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 9 01:02:12 2017 +0200 lib1521: fix compiler warnings on the use of bad 'long' values Reported-by: Marcel Raad Bug: https://github.com/curl/curl/commit/cccac4fb2b20d6ed87da7978408c3ecacc464fe4#commitcomment-22453387 commit 844896d06416c9fdcacad5159f2a1a1d0293b9e5 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 9 01:00:23 2017 +0200 setopt: check CURLOPT_ADDRESS_SCOPE option range ... and return error instead of triggering an assert() when being way out of range. commit 01596dbadf5515da6282b210dcaf2dba724c7e81 Author: TheAssassin <TheAssassin@users.noreply.github.com> Date: Mon Jun 5 01:02:56 2017 +0200 cmake: Fix inconsistency regarding mbed TLS include directory Previously, one had to set MBEDTLS_INCLUDE_DIR to make CMake find the headers, but the system complained that mbed TLS wasn't found due to MBEDTLS_INCLUDE_DIRS (note the trailing s) was not set. This commit attempts to fix that. Closes https://github.com/curl/curl/pull/1541 commit bc164de7b392dd1f1ffd6013458e32caf03f03cc Author: Ryuichi KAWAMATA <iam@rkmathi.net> Date: Thu Jun 8 23:17:59 2017 +0900 examples/multi-uv.c: fix deprecated symbol Closes #1557 commit 6c5907452804013a0bbf7360f6b50c8e7e90cee7 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Jun 8 11:06:19 2017 +0200 asyn-ares: s/Curl_expire_latest/Curl_expire commit 7fffe97b787b962fc0afcd5737cec411f2bc0023 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Jun 8 08:34:32 2017 +0200 expire: remove Curl_expire_latest() With the introduction of expire IDs and the fact that existing timers can be removed now and thus never expire, the concept with adding a "latest" timer is not working anymore as it risks to not expire at all. So, to be certain the timers actually are in line and will expire, the plain Curl_expire() needs to be used. The _latest() function was added as a sort of shortcut in the past that's quite simply not necessary anymore. Follow-up to 31b39c40cf90 Reported-by: Paul Harris Closes #1555 commit 165b7f50991277699fc7dc4758ec7f501372a75a Author: Chris Carlmar <chris@carlmar.no> Date: Wed Jun 7 23:34:24 2017 +0200 configure: fix link with librtmp when specifying path Bug: https://curl.haxx.se/mail/lib-2017-06/0017.html commit 68c6dcb2cb682bc7363cdf3d2e58da225cf4e72e Author: Daniel Stenberg <daniel@haxx.se> Date: Wed Jun 7 13:29:46 2017 +0200 file: make speedcheck use current time for checks ... as it would previously just get the "now" timestamp before the transfer starts and then not update it again. Closes #1550 commit f7ee701c612426cb83c7e8e08c75b4b9febed6a3 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed Jun 7 14:00:23 2017 +0200 metalink: remove unused printf() argument commit e100afb4d8697e9c5f0e4b34b3b6f2b45337e442 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Jun 6 14:40:36 2017 +0200 travis: let some builds *not* use --enable-debug typecheck-gcc and other things require optimized builds Closes #1544 commit bacb909e136b9fc56cf438eaf0f9d7561d9be775 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Jun 6 14:40:36 2017 +0200 README.md: show the coverall coverage on github commit de0adda78c4c3ce6d221beefdcd4492412dcf287 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Jun 6 00:21:12 2017 +0200 lib1521: fix compiler warnings commit 798b2e196427af6a928efb451643bd3a317508dc Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 5 15:21:26 2017 +0200 test1521: make the code < 80 columns wide commit 38125e7f7ed899d07aecd6599de17cbd76ed5422 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 5 14:56:32 2017 +0200 test1121: use stricter types to work with typcheck-gcc commit b8085f493a7066fe6990c15e8e30d8b20c736062 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 5 14:56:13 2017 +0200 typecheck-gcc: allow CURLOPT_STDERR to be NULL too commit cccac4fb2b20d6ed87da7978408c3ecacc464fe4 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 5 11:57:47 2017 +0200 test1521: test *all* curl_easy_setopt options mk-lib1521.pl generates a test program (lib1521.c) that calls curl_easy_setopt() for every known option with a few typical values to make sure they work (ignoring the return codes). Some small changes were necessary to avoid asserts and NULL accesses when doing this. The perl script needs to be manually rerun when we add new options. Closes #1543 commit b95a07ea59e3ebab9d643e67084459be13c93a3d Author: Dan Fandrich <dan@coneharvesters.com> Date: Mon Jun 5 11:26:39 2017 +0200 test1538: added "verbose logs" keyword These error messages are not displayed with --disable-verbose commit 1573ebee8a8720f4d5eca35d8046370e47f48f43 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Jun 5 10:33:51 2017 +0200 test1262: verify ftp download with -z for "if older than this" commit 796044273009a4ffc2b85eaebf0d44e427c3d8f4 Author: Marcel Raad <raad@teamviewer.com> Date: Mon Jun 5 00:27:29 2017 +0200 curl_ntlm_core: use Curl_raw_toupper instead of toupper This was the only remaining use of toupper in the entire source code. Suggested-by: Daniel Stenberg commit 6b9f4f7f0f66aa083f69cfdb0373df989e583a2c Author: Daniel Stenberg <daniel@haxx.se> Date: Sun Jun 4 23:26:41 2017 +0200 RELEASE-NOTES: synced with 65ba92650 commit 892c5e4cb3af997c232e323b8831af6e8637a84d Author: Marcel Raad <raad@teamviewer.com> Date: Sun Jun 4 16:46:03 2017 +0200 curl_ntlm_core: pass unsigned char to toupper Otherwise, clang on Cygwin64 warns: curl_ntlm_core.c:525:35: error: array subscript is of type 'char' [-Werror,-Wchar-subscripts] dest[2 * i] = (unsigned char)(toupper(src[i])); ^~~~~~~~~~~~~~~ /usr/include/ctype.h:152:25: note: expanded from macro 'toupper' (void) __CTYPE_PTR[__x]; (toupper) (__x);}) ^~~~ commit 65ba92650df941d9568852fd6e8fb07cdbd67638 Author: Mahmoud Samir Fayed <msfclipper@yahoo.com> Date: Sun Jun 4 06:32:43 2017 +0300 BINDINGS: add Ring binding Closes https://github.com/curl/curl/pull/1539 commit c3ad22697c261d266db8620c3594b669e34881d9 Author: Daniel Stenberg <daniel@haxx.se> Date: Sun Jun 4 00:19:57 2017 +0200 CONTRIBUTE.md: mention tests done on pull requests commit 7bbb78c7418518fda812831b8899cda0fafa2ef8 Author: Daniel Stenberg <daniel@haxx.se> Date: Sat Jun 3 23:27:13 2017 +0200 travis: add coverage, distcheck and cmake builds Closes #1534 commit a1b275a41ec5d479b3701ac618d2c9c11d5cedc3 Author: Marcel Raad <raad@teamviewer.com> Date: Sat Jun 3 20:18:34 2017 +0200 libtest: fix int-in-bool-context warnings GCC 7 complained: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] commit 0932573e7cf83e3dd8037a318fa166b127e4d9a5 Author: Marcel Raad <raad@teamviewer.com> Date: Sat Jun 3 20:12:23 2017 +0200 libtest: fix implicit-fallthrough warnings with GCC 7 commit 15136a526847ea4d9490e8e5744834df9f6701b2 Author: Marcel Raad <raad@teamviewer.com> Date: Sat Jun 3 20:10:52 2017 +0200 x509asn1: fix implicit-fallthrough warning with GCC 7 commit f8518059cecfaf2b338389cef7f71f145b21226d Author: Marcel Raad <raad@teamviewer.com> Date: Sat Jun 3 11:59:38 2017 +0200 curl_sasl: fix unused-variable warning This fixes the following warning with CURL_DISABLE_CRYPTO_AUTH, as seen in the autobuilds: curl_sasl.c:417:9: warning: unused variable 'serverdata' [-Wunused-variable] commit 191349eb75b06728760879f374fb8e78ddd9781f Author: Daniel Stenberg <daniel@haxx.se> Date: Sat Jun 3 00:45:02 2017 +0200 updatemanpages.pl: error out on too old git version commit 7207affe28f414e4585230ba65d2e1b7ecc30ef5 Author: Marcel Raad <raad@teamviewer.com> Date: Fri Jun 2 23:02:54 2017 +0200 cyassl: define build macros before including ssl.h cyassl/ssl.h needs the macros from cyassl/options.h, so define them before including cyassl/ssl.h the first time, which happens in urldata.h. This broke the build on Ubuntu Xenial, which comes with WolfSSL 3.4.8 and therefore redefines the symbols from cyassl/options.h instead of including the header. Closes https://github.com/curl/curl/pull/1536 commit 5233de9ac66035ad3bc0d04dffd81fb50d58fb5b Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 14:13:02 2017 +0200 tool_util: remove unused tvdiff_secs and remove tool_ prefix Closes #1532 commit cfd3e8f399c2bb2a7fdc51f01ddc12548b4f3892 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 17:50:45 2017 +0200 dedotdot: fixed output for ".." and "." only input Found when updating test 1395, which I did to increase test coverage of this source file... Closes #1535 commit 10e02bc36a92a1d33067d72906784441d626c010 Author: Marcel Raad <raad@teamviewer.com> Date: Fri Jun 2 22:05:01 2017 +0200 mbedtls: make TU-local variable static mbedtls_x509_crt_profile_fr is only used locally. This fixes a missing-variable-declarations warning with clang. commit 769890c7e231b23962580c42df003967060a30fd Author: Marcel Raad <raad@teamviewer.com> Date: Fri Jun 2 21:58:48 2017 +0200 MD(4|5): silence cast-align clang warning Unaligned access is on purpose here and the warning is harmless on affected architectures. GCC knows that, while clang warns on all architectures. commit 61d4870dc9c7a0d78d9ae54d95b41d383770a522 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 15:52:59 2017 +0200 test1538: fix typo commit cef9c9e7828fdf073e6430d7bfdefa19e25c5540 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 13:52:55 2017 +0200 test1538: verify the libcurl strerror API calls commit 4ba20a511995b2179e59cf6d1880176d2d454bad Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 08:32:36 2017 +0200 curl_endian: remove unused functions Closes #1529 commit 9b2dfe88bba160922e049ae9a19db585b65cbd56 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 13:16:13 2017 +0200 test1537: dedicated tests of the URL (un)escape API calls Closes #1530 commit b5e143e7a562a6765077110fe60bccdb8b6bb7d2 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 09:25:02 2017 +0200 coverage: run event tests too ... the torture ones are commented out only because they are slooooow. commit f6e0f4556eabc8c2629d16ae599a153392d30d05 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri Jun 2 00:59:35 2017 +0200 build: provide easy code coverage measuring Closes #1528 commit efc7c1d86f1543870712d1a0ef4eecd67e933921 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Jun 1 15:03:30 2017 +0200 typecheck-gcc.h: check CURLINFO_CERTINFO ... and update the certinfo.c example accordingly. Fixes https://github.com/curl/curl/issues/846 commit 4eafc6c249cd390938cc3216e07571e0fc885bb3 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Jun 1 14:55:05 2017 +0200 typecheck-gcc.h: check CURLINFO_TLS_SSL_PTR and CURLINFO_TLS_SESSION ... so that they get the required "struct curl_tlssessioninfo **" arguments. commit 5fe4f7890221b6ff12967af83ce0f14c05f1e2b0 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Jun 1 14:47:18 2017 +0200 typecheck-gcc.h: separate getinfo slist checks from other pointers Fixes #1524 commit 5e796c5e94e442797b6fe93aa81ff32b41dfb715 Author: Marcel Raad <raad@teamviewer.com> Date: Thu Jun 1 17:46:32 2017 +0200 curl-compilers.m4: escape square brackets in regex Otherwise, they are removed in the final configure file. Also changed sed to "$SED" like in most other calls in this file. commit 5598b0bd63f690c151074494ce47ef872f004ab4 Author: Marcel Raad <raad@teamviewer.com> Date: Wed May 31 22:21:42 2017 +0200 curl-compilers.m4: fix compiler_num for clang "clang -dumpversion" always returns "4.2.1", the GCC version that clang was initially compatible to. Use "clang -v" instead, which returns the actual clang version. Fixes https://github.com/curl/curl/issues/1522 Closes https://github.com/curl/curl/pull/1523 commit c5de7f50f73919ead96aa1b541090cb25d63b012 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 23:22:46 2017 +0200 examples/externalsocket.c: s/closesocket/closecb ... since closesocket is a function in WinSock. Reported-by: Marcel Raad Bug: https://github.com/curl/curl/commit/55fcb8485914700132fd1854c9509b66c955efbe#co mmitcomment-22347818 commit 45cecfbd33b121c864cbb7b83ea63f749e99f424 Author: Marcel Raad <raad@teamviewer.com> Date: Wed May 31 19:05:50 2017 +0200 lib583: fix compiler warning Use CURLMcode for variable 'res' and cast to int where necessary instead of the other way around. Other tests do the same. This fixes the following clang warning: lib583.c:68:15: warning: cast from function call of type 'CURLMcode' to non-matching type 'int' [-Wbad-function-cast] commit aae4a4788a4949d85069c5959c860969dc614be7 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 13:52:03 2017 +0200 CURLOPT_SSH_KEY*.3: typos Reported-by: Gisle Vanem commit 399a1a618270b7b352d32bcd8c4e5e9d47dc3316 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 13:39:56 2017 +0200 CURLOPT_STREAM_DEPENDS.3: typo commit f072393febfc8dfefa88a8c0f9d04c4312810779 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 13:36:51 2017 +0200 CURLOPT_FNMATCH_FUNCTION.3: also modified example to avoid fcpp issues commit 28baf380fa339ffdec9cba0d4bb22c3758c27428 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 13:30:04 2017 +0200 CURLOPT_FNMATCH_DATA.3: modified example to avoid fcpp issues commit 4600362a5af3970bbaef545af1d7a6cf90201127 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 11:56:28 2017 +0200 opts: more than 100 more examples for man pages... commit 69a6cc2e135fbecc5fd21a1bc8cf4d8dfe0dc030 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 09:55:44 2017 +0200 libtest/lib574.c: use correct callback proto commit 501b9ebe9289cb4afd3766688644fbcde7d25ad0 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 09:32:04 2017 +0200 examples/sampleconv.c: indent changes, made callbacks static commit 55fcb8485914700132fd1854c9509b66c955efbe Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 09:26:51 2017 +0200 example/externalsocket.c: make it use CLOSESOCKETFUNCTION too commit 314a7fa3ceb74f90cc7cce28bef7517ef874f64c Author: Marcel Raad <Marcel.Raad@teamviewer.com> Date: Tue May 30 10:07:47 2017 +0200 curl-compilers.m4: enable -Wshift-sign-overflow for clang clang 2.9+ supports -Wshift-sign-overflow, which warns about undefined behavior on signed left shifts when shifting by too many places. Ref: https://github.com/curl/curl/issues/1516 Closes https://github.com/curl/curl/pull/1517 commit a6ad28a75e55859f6bb66a1eaf339154f59691a8 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 31 08:45:36 2017 +0200 CURLOPT_PROXY.3: fix test 1140 breakage commit 534056297fc70b212f75368bc517eb163b3c5658 Author: Jay Satiro <raysatiro@yahoo.com> Date: Wed May 31 01:40:39 2017 -0400 build-wolfssl: Sync config with wolfSSL 3.11 wolfSSL configure script relevant changes from 3.10 to 3.11: - Async threading support added; disabled by default without async crypto, which continues to be disabled by default. wolfSSL configure script relevant changes from 3.11 to 3.11.1 (beta): - TLS 1.3 beta support added; disabled by default. For experimenting I put in a comment block the defines needed to enable TLS 1.3 support (ie the equivalent of --enable-tls13). commit bb1a8c174bc2407451b71842d970f5f7b395a2f1 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 30 23:35:30 2017 +0200 opts: more examples added to man pages commit 2d5fa35e85c6e0ba84e6922e321bbe3a4511cdf9 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 30 22:43:34 2017 +0200 docs: clarify NO_PROXY further Fixes #1208 commit dd97551746dca747c2e624ca81cadb6985199826 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 30 18:05:33 2017 +0200 CURLOPT_PROXY.3: describe the environment variables more commit e54db1b053614ce5d332b5eea673ab370843e65b Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 30 00:45:54 2017 +0200 transfer: init the infilesize from the postfields... ... with a strlen() if no size was set, and do this in the pretransfer function so that the info is set early. Otherwise, the default strlen() done on the POSTFIELDS data never sets state.infilesize. Reported-by: Vincas Razma Bug: #1294 commit 35682764a9dc7eb0fed3fbb1c0074f1c34dd60b2 Author: Jay Satiro <raysatiro@yahoo.com> Date: Mon May 29 18:04:53 2017 -0400 test557: fix ubsan runtime error due to int left shift - Test curl_msnprintf negative int width arg using INT_MIN instead of 1 << 31 which is undefined behavior. Closes https://github.com/curl/curl/issues/1516 commit 35e9281ef8ac394b7d718cf6bd65bdc2ff8047b0 Author: Jay Satiro <raysatiro@yahoo.com> Date: Mon May 29 17:38:33 2017 -0400 mbedtls: fix variable shadow warning vtls/mbedtls.c:804:69: warning: declaration of 'entropy' shadows a global declaration [-Wshadow] CURLcode Curl_mbedtls_random(struct Curl_easy *data, unsigned char *entropy, ^~~~~~~ commit 3558e14967da81c42fc0e89bd9d553db82a5a39e Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 29 09:42:03 2017 +0200 RELEASE-NOTES: synced with 3aaac8c2f commit 3aaac8c2f70556771d4924e5e5d235a196c8698d Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun May 28 23:07:35 2017 +0200 tests: removed some redundant empty <stdout> sections commit 01f94879670ceb3b5d2ff7bf5017eab6f0abb98c Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun May 28 20:57:47 2017 +0200 runtests.pl: removed <precommand> feature This hasn't been used in over a decade. <precheck> can still be used to run commands before the main test. commit c2227dae53e88fc0e39bb8c48bfad917e0c7b11e Author: Daniel Stenberg <daniel@haxx.se> Date: Sat May 27 23:11:26 2017 +0200 opts: more examples added in option man pages commit 14514c97968c1ad26b15e140083565e85a4d2b47 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 27 14:30:24 2017 +0200 runtests.pl: removed unused arguments to valgrindparse commit d90b729c3b5aa6122f67d2ee21c718a0bc93e5dd Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 25 21:54:26 2017 +0200 TODO: 6.4 is done, send telnet data in chunks commit a9de0a9f54c1a4858f0f10162d348fa506242577 Author: Phil Crump <phil@philcrump.co.uk> Date: Thu May 25 12:51:35 2017 +0100 docs/CURLOPT_SSLVERSION.3: Correct define name in example Closes #1509 commit 59cc0234e5be31d40aa91951984e8e00ca54f0ec Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 25 13:01:44 2017 +0200 ssh: fix 'left' may be used uninitialized follow-up to f31760e63b4e Reported-by: Michael Kaufmann Bug: https://github.com/curl/curl/pull/1495#issuecomment-303982793 commit 8ab22a74533acee61af31c48e75269822f408cb4 Author: Michael Kaufmann <mail@michael-kaufmann.ch> Date: Sat May 20 19:39:51 2017 +0200 time: fix type conversions and compiler warnings Fix bugs and compiler warnings on systems with 32-bit long and 64-bit time_t. Reviewed-by: Daniel Stenberg Closes #1499 commit b4d87f54d60711e936fefae388d741b281eecdf0 Author: Marcel Raad <Marcel.Raad@teamviewer.com> Date: Wed May 24 11:56:38 2017 +0200 examples: fix Wimplicit-fallthrough warnings This is contained in -Wextra with GCC 7. commit df45f2c33e1c916d62d7f5e794c6015fc3b51c01 Author: Anatol Belski <ab@php.net> Date: Fri Mar 10 12:59:36 2017 +0100 winbuild: fix the nghttp2 build Closes #1321 commit 63cd0d60ea24a7c7de4289a4240d40fa4ac46ff2 Author: Sergei Nikulov <snikulov@users.noreply.github.com> Date: Wed May 24 01:03:29 2017 +0300 LDAP: documentation update per #878 changes (#1506) commit bba59073c52e6dd00ddc18e0e40d1f7dfc1c9315 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 23 10:32:18 2017 +0200 redirect: store the "would redirect to" URL when max redirs is reached Test 1261 added to verify. Reported-by: Lloyd Fournier Fixes #1489 Closes #1497 commit 48f2a96a609aec535736a7fe202163fdb2a99fd5 Author: Sergei Nikulov <snikulov@users.noreply.github.com> Date: Wed May 24 00:14:13 2017 +0300 LDAP: fixed checksrc issue commit f0fe66f13c93d3d0af45d9fb1231c9164e0f9dc8 Author: Sergei Nikulov <snikulov@users.noreply.github.com> Date: Tue May 23 22:45:39 2017 +0300 LDAP: using ldap_bind_s on Windows with methods (#878) * LDAP: using ldap_bind_s on Windows with methods(BASIC/DIGEST/NTLM/AUTONEG) * ldap: updated per build options handling * ldap: fixed logic for auth selection commit b4d6b994454890269e79b439ac5d1492a626e9a6 Author: Akhil Kedia <akhil.kedia@samsung.com> Date: Mon May 22 17:34:45 2017 +0900 cmake: fix build on Ubuntu 14.04 Fixed a syntax error with setting cache variables (The type and docstring were missing), resulting in build errors. Quoted the CURL_CA_PATH and CURL_CA_BUNDLE otherwise the path was written without quotes in C code, resulting in build errors. Closes #1503 Signed-off-by: Akhil <akhil.kedia@samsung.com> commit a1b3a95c96adb9624358c26976c5d22adeaab6ed Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 23 07:41:52 2017 +0200 url: fix declaration of 'pipe' shadows a global declaration follow-up to 4cdb1be8246c commit 945919db5b42f40a174598ba73e54b775bf85faf Author: Kamil Dudka <kdudka@redhat.com> Date: Mon May 22 19:00:15 2017 +0200 memdebug: fix compilation failure .... caused by a typo in the last commit (fixing issue #1504): memdebug.c: In function ‘curl_fclose’: memdebug.c:444:3: error: implicit declaration of function ‘DEBUGDEBUGASSERT’ [-Werror=implicit-function-declaration] commit 8589e1fe30773e10c50b9a65d4f96eeb8434233c Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 22 13:58:17 2017 +0200 assert: avoid, use DEBUGASSERT instead! ... as it does extra checks to actually work. Reported-by: jonrumsey at github Fixes #1504 commit fab9629133025e2d9517334535908200802b5e96 Author: Simon Warta <simon@kullo.net> Date: Tue May 2 00:26:08 2017 +0200 cmake: remove unused variables: GNUTLS_ENABLED, NSS_ENABLED commit 2ea297564da508e96e2c720479be2afa0594027b Author: Simon Warta <simon@kullo.net> Date: Tue May 2 00:18:18 2017 +0200 cmake: remove CURL_CA_BUNDLE from cmake TODO commit 6a9489dc4512bf92e121d7bc08924e2922ababc0 Author: Simon Warta <simon@kullo.net> Date: Tue May 2 00:12:55 2017 +0200 cmake: auto detection of CURL_CA_BUNDLE/CURL_CA_PATH Closes #1461 commit 8256cce2c7ae2b13fc4790ab08623cee17ac612c Author: Simon Warta <simon@kullo.net> Date: Mon May 1 22:15:15 2017 +0200 cmake: add CURL_CA_BUNDLE/CURL_CA_FALLBACK/CURL_CA_PATH options commit 5606fcc657ecbe113b6dcdcd26e79e7fa7fbea42 Author: Simon Warta <simon@kullo.net> Date: Sun Feb 26 22:41:33 2017 +0100 cmake: Add CURL_CA_FALLBACK to curl_config.h.cmake This is for symmetry with the autoconf generated curl_config.h.in commit edd7603e99e82b9edb3aa2cf4ced47cf18d163d2 Author: Daniel Stenberg <daniel@haxx.se> Date: Sun May 21 00:26:27 2017 +0200 RELEASE-NOTES: synced with 052a14e3c commit 052a14e3cda7ea16729a4403b60bc94907c561b7 Author: Michael Kaufmann <mail@michael-kaufmann.ch> Date: Tue May 16 21:29:59 2017 +0200 tests: stabilize test 1034 Pass the invalid domain name on stdin. On some systems, the test framework cannot pass invalid UTF-8 sequences on the command line. Closes #1488 commit f31760e63b4e9ef1eb25f8f211390f8239388515 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 18 13:04:52 2017 +0200 ssh: ignore timeouts during disconnect ... as otherwise it risks not cleaning up the libssh2 handle properly which leads to memory leak! Assisted-by: Joel Depooter Closes #1495 Closes #1479 Bug: https://curl.haxx.se/mail/lib-2017-04/0024.html commit e5491e0f9c876c84516f8a3bb7060a3c82e0a830 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 19 14:25:16 2017 +0200 ghiper.c/hiperfifo.c: add comment about missing timer functionality It takes someone to read up on the APIs of these libraries to figure out how to do this correctly. Reported-by: Michael Kaufmann Closes #1253 commit d6bb1f1d563dd3748813ad7b6f617ddefc3194dd Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 19 14:16:37 2017 +0200 asiohiper.cpp / evhiperfifo.c: deal with negative timerfunction input That means delete the timer. Reported-by: Michael Kaufmann Ref: #1253 commit ce73a30168ee1117984a21a366b05931e87caaad Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 18 23:11:45 2017 +0200 cmdline-opts/write-out.d: s/-L/--location Since the man page generator wants the long option name version to generate the proper output. commit b4cfda8a4aa885b444ac2b71adbbe87906545026 Author: Bernhard M. Wiedemann <bwiedemann@suse.de> Date: Wed May 17 15:54:19 2017 +0200 mkhelp.pl: do not add current time into curl binary ... as part of hugehelpgz rodata to make build reproducible. See https://reproducible-builds.org/ for why this is good Closes #1490 commit a6f657911e19c234739b3fe2e5519f041e69753b Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 17 10:55:12 2017 +0200 oauth2-bearer.d: mention the <token> argument commit c58063b4f828f47e4a7ed6c8c6cbd286d1162afc Author: Nick Zitzmann <nickzman@gmail.com> Date: Tue May 16 19:21:12 2017 -0500 darwinssl: Fix exception when processing a client-side certificate file if no error was raised by the API but the SecIdentityRef was null Fixes #1450 commit 32c27f9e98e3b6195b0e465df853a98a4702fb01 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 16 16:13:03 2017 +0200 curl_sasl: fix build error with CURL_DISABLE_CRYPTO_AUTH + USE_NTLM Reported-by: wyattoday at github Fixes #1487 commit 4fcc0b09fb000e72ad5b3f4c3473d87026470d09 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 16 08:49:11 2017 +0200 docs/cmdline-opts/config.d: edit for language commit 590991d07ae6e8eaa1aec309fa0f92b239d002ee Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 15 23:19:45 2017 +0200 RELEASE-NOTES: synced with eb16305e6 commit eb16305e6ab1b3d660b6de326f61fd4c7df086ac Author: moparisthebest <admin@moparisthebest.com> Date: Mon Apr 17 19:47:51 2017 -0400 SecureTransport/DarwinSSL: Implement public key pinning Closes #1400 commit 19195696338b9a63fcc5ca42d8238cbe54e2afc2 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 15 13:00:48 2017 +0200 man pages: fix example syntax errors follow-up to 5ddad099b42b50 commit 5ddad099b42b505a9449738db124ed6b1389afc1 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 15 11:45:19 2017 +0200 docs/libcurl/opts: added more examples in man pages commit e366ca2b85a78a0ad8d663534bd462e61ad407b5 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 15 10:11:23 2017 +0200 CURLOPT_HTTPPROXYTUNNEL: clarify, add example commit 180c75eb63ae95c41c692957ccd13321e44d4e9e Author: Daniel Stenberg <daniel@haxx.se> Date: Sun May 14 17:09:45 2017 +0200 curl: show the libcurl release date in --version output ... and support and additional "security patched" date for those who enhance older versions that way. Pass on the define CURL_PATCHSTAMP with a date for that. Building with non-release headers shows the date as [unreleased]. Also: this changes the date format generated in the curlver.h file to be "YYYY-MM-DD" (no name of the day or month, no time, no time zone) to make it easier on the eye and easier to parse. Example (new) date string: 2017-05-09 Suggested-by: Brian Childs Closes #1474 commit d836c9fee4bbef249dc7bf281336fb41eb3b77c7 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 13 22:54:59 2017 +0200 url.c: add a compile-time check that CURL_MAX_WRITE_SIZE is large enough Some code (e.g. Curl_fillreadbuffer) assumes that this buffer is not exceedingly tiny and will break if it is. This same check is already done at run time in the CURLOPT_BUFFERSIZE option. commit b1fa80b84facb94a667a6bfaa99476a161285b0d Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 13 22:57:49 2017 +0200 lib510: don't write past the end of the buffer if it's too small commit 646dc1c42a57298a487fceac4e62cae2b420e78f Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 13 22:35:15 2017 +0200 tests: added missing keywords "chunked Transfer-Encoding" commit d5649c91a18d559af3e54e782f0333a94d9b7362 Author: Daniel Stenberg <daniel@haxx.se> Date: Sat May 13 21:14:59 2017 +0200 THANKS: add a few missing names ... I found them in the commit logs from the early years commit fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 13 19:04:10 2017 +0200 tests: made a couple of prechecks consistent with others Also removed a TODO suggesting caching the precheck results. Tests showed this would save about 0.1 sec on the total test run time on a relatively modern system, an unnoticeable gain at the cost of longer and more complicated code. There would also be a danger that a cached test result would be inappropriately returned, such as when other test dependencies (like environment variables) are different or when the precheck causes side effects (like filesystem changes). commit 6d49695bcabe14108056c429cffdaee950242318 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 12 19:58:06 2017 +0200 FAQ: add 7.4 to toc ... and delete trailing whitespace Fixes #1484 commit d6c74ff663100d600a04debea35d0bc986adb213 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 12 17:19:30 2017 +0200 multi: remove leftover debug infof() calls from e9fd794a6 commit 4cdb1be8246caefd0c0e777f6da4128d7f51b2a2 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 12 16:29:06 2017 +0200 pipeline: fix mistakenly trying to pipeline POSTs The function IsPipeliningPossible() would return TRUE if either pipelining OR HTTP/2 were possible on a connection, which would lead to it returning TRUE even for POSTs on HTTP/1 connections. It now returns a bitmask so that the caller can differentiate which kind the connection allows. Fixes #1481 Closes #1483 Reported-by: stootill at github commit bc3866e3eb3f4da60bb0d6fbe8e4e38ae8ce943f Author: Ron Eldor <Ron.Eldor@arm.com> Date: Tue May 9 16:57:19 2017 +0300 mbedtls: Support server renegotiation request Tested with servers: IIS 7.5; OpenSSL 1.0.2. Closes https://github.com/curl/curl/pull/1475 commit 77b90997dd228b071603c9ade96a16610a6df222 Author: Marcel Raad <Marcel.Raad@teamviewer.com> Date: Thu May 11 09:59:56 2017 +0200 cookie_interface: fix -Wcomma warning clang 5.0 complains: possible misuse of comma operator here [-Wcomma] commit b875250e32048070401f5a3a23cdd9f47b15e114 Author: Marcel Raad <Marcel.Raad@teamviewer.com> Date: Thu May 11 10:01:58 2017 +0200 formdata: fix -Wcomma warning clang 5.0 complains: possible misuse of comma operator here [-Wcomma] Change the comma to a semicolon to fix that. commit 31b39c40cf909d34f27dc655755f346482f57089 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 9 12:47:49 2017 +0200 multi: use a fixed array of timers instead of malloc ... since the total amount is low this is faster, easier and reduces memory overhead. Also, Curl_expire_done() can now mark an expire timeout as done so that it never times out. Closes #1472 commit e9fd794a616c10bd0d017a76f8fdccaf4cc76851 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 9 12:47:49 2017 +0200 multi: assign IDs to all timers and make each timer singleton A) reduces the timeout lists drastically B) prevents a lot of superfluous loops for timers that expires "in vain" when it has actually already been extended to fire later on commit 8dfa378e528917fd253780fd8414795ed868ab0f Author: Richard Hsu <richard@accompani.com> Date: Tue May 9 14:30:15 2017 -0700 tests: remove superfluous test 1399 @MarcelRaad noted that `test1399` causes infinite loop on MinGW. Looking into this, seems like it is related to how Windows handles CRLF. See https://github.com/curl/curl/commit/9e093f by @mback2k. Removing `test1399` as it's identical to `test1326` then with such a fix. Test 1399 was broughy by commit 862b02f8947039e Closes #1478 commit f19baf27ebf89bea3768471be3c89772dc8a0be5 Author: Dan Fandrich <dan@coneharvesters.com> Date: Tue May 9 19:49:17 2017 +0200 tests: make test file names more unique Include the test number in the names of files written out by tests to reduce the chance of accidental duplication and to make it more clear which test is associated with which file. commit f5b71d3a6c4b2e818214c154235e80ecefd39778 Author: Dan Fandrich <dan@coneharvesters.com> Date: Tue May 9 19:43:22 2017 +0200 tests: removed redundant --trace-ascii arguments This is already added by the test suite; it's not clear why all these tests had it, unless it's cargo-culting. commit 4dc8499494dc16bf336c1055f2ae4b78c709c87d Author: Marcel Raad <raad@teamviewer.com> Date: Tue May 9 19:20:28 2017 +0200 tool: fix remaining -Wcast-qual warnings Avoid casting away low-level const. commit 158d7016419429e7741ec35d0d6e256985762347 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 9 09:08:25 2017 +0200 formboundary: convert assert into run-time check ... to really make sure the boundary fits in the target buffer. Fixes unused parameter 'buflen' warning. Reported-by: Michael Kaufmann Bug: https://github.com/curl/curl/pull/1468#issuecomment-300078754 commit 2f6bfd54997904457991fd6897ddbc309d3292ad Author: Dan Fandrich <dan@coneharvesters.com> Date: Tue May 9 00:36:38 2017 +0200 tests: list the primary server first in the server section commit 8b2f22ed29dc06eb55941c82c6ee48bdd7542487 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 8 23:30:29 2017 +0200 curl: generate the --help output ... using the docs/cmdline-opts/gen.pl script, so that we get all the command line option documentation from the same source. The generation of the list has to be done manually and pasted into the source code. Closes #1465 commit 73afcfc0ae5dc70821d5f1ac0b1f897fd67efe97 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 8 23:23:29 2017 +0200 tests: updated for modified fake random commit 1cafede9f2b4a838dfc80423415e60704b3346f9 Author: Jay Satiro <raysatiro@yahoo.com> Date: Mon May 8 23:23:28 2017 +0200 rand: treat fake entropy the same regardless of endianness When the random seed is purposely made predictable for testing purposes by using the CURL_ENTROPY environment variable, process that data in an endian agnostic way so the the initial random seed is the same regardless of endianness. - Change Curl_rand to write to a char array instead of int array. - Add Curl_rand_hex to write random hex characters to a buffer. Fixes #1315 Closes #1468 Co-authored-by: Daniel Stenberg Reported-by: Michael Kaufmann commit 9e9509e46a9db909e4c0a2ce0ac1ef5c94fcb3a4 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun May 7 15:02:02 2017 +0200 tests: give each stunnel.conf file a unique name Otherwise, subsequent uses of stunnel overwrite the configuration file of previous invocations so they can no longer be inspected. commit dc1a1b50557ed0cad427e0b5808a95459443ca41 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 8 20:23:44 2017 +0200 tool_msgs: remove wrong cast Commit 481e0de00a9003b9c5220b120e3fc302d9b0932d changed the variable type from int to size_t, so don't cast the result of strlen to int anymore. commit e076fdaf5bb7862670cf4e0e5d6ba5861dd3b6e9 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 8 20:09:32 2017 +0200 tftpd: fix signed/unsigned mismatch warnings alarm's argument is unsigned. commit 141ed8ca09e0650879d2333ecce19ff1b339b895 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 8 19:59:46 2017 +0200 libtest: fix MinGW-w64 warnings long is 32 bits while size_t is 64 bits on MinGW-w64, so typecheck-gcc.h complains when using size_t for a long option. Also, curl_socket_t is unsigned long long rather than int. commit 78007305203140162f567fd611182cfc41ac51dd Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 8 15:10:09 2017 +0200 curl.1: depend the build on the Makefile.inc too ... to also make it update when we remove files, like we did for --environment in commit a8e388dd1095. commit f27c884be8c35287569b7fc909c9a2455d5e38e3 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 8 10:18:30 2017 +0200 RELEASE-NOTES: synced with e3f84efc32d6b01a commit e3f84efc32d6b01a605c93b39668653049c15188 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 8 10:08:48 2017 +0200 runtests: fix "use of undefined value" warning in -R handling commit e2b394106d543c4615a60795b7fdce04bd4e5090 Author: Marcel Raad <raad@teamviewer.com> Date: Fri May 5 09:37:05 2017 +0200 test537: use correct variable type Avoids narrowing conversion warnings because rlim_t is usually unsigned long. Closes https://github.com/curl/curl/pull/1469 commit d99acd937a01ee7111c347e08c1f25cea54a6ab9 Author: Marcel Raad <raad@teamviewer.com> Date: Sun May 7 22:14:28 2017 +0200 sendrecv: fix MinGW-w64 warning The first argument to select is an int, while curl_socket_t is unsigned long long when using WinSock. It's ignored anyway [1]. [1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms740141.aspx commit f67aa4d31c41eb91b0339cc66da5a199e70e7b4b Author: Marcel Raad <raad@teamviewer.com> Date: Sun May 7 20:27:12 2017 +0200 tool_parsecfg: fix -Wcast-qual warning Don't convert string literal to char * before assigning it to const char *. commit ea1b86478662dce1c3f1ce417180efd5d998c883 Author: Marcel Raad <raad@teamviewer.com> Date: Sun May 7 19:02:34 2017 +0200 asyn-thread: fix unused macro warnings Don't do anything in this file if CURLRES_THREADED is not defined. commit 3661c8aeb0c6b6f5cb935d5b00d5663df4c66821 Author: Marcel Raad <raad@teamviewer.com> Date: Sun May 7 16:26:19 2017 +0200 tftp: silence bad-function-cast warning The cases this warns about are handled elsewhere, so just use an intermediate variable to silence the warning. commit 6c7f1f741bcbf8e408c9c7ced078cd1cef70af2c Author: canavan at github <canavan@users.noreply.github.com> Date: Sun May 7 00:06:56 2017 +0200 buildconf: fix hang on IRIX Apparently, /usr/bin/m4 ignores the --version parameter and waits for input from stdin. Fixes #1471 commit 289236b223db7baa04c7f1c586f321c8ac04e98a Author: Daniel Stenberg <daniel@haxx.se> Date: Sat May 6 23:51:29 2017 +0200 opts: fix bad example formatting \n => \\n ...to render properly nroff. commit 271c63748ada2fa04a25481990e3d7a55d08bed0 Author: Daniel Stenberg <daniel@haxx.se> Date: Sat May 6 23:38:39 2017 +0200 opts: examples added to 8 more libcurl option man pages commit a8e388dd1095d3ffa12fc75f2bec70f1f9b66c80 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 3 14:28:40 2017 +0200 curl: remove tool_writeenv.[ch] ... and USE_ENVIRONMENT and --environment. It was once added for RISC OS support and its platform specific behavior has been annoying ever since. Added in commit c3c8bbd3b2688da8e, mostly unchanged since then. Most probably not actually used for years. Closes #1463 commit ba5fa1c7a825da75da6f0686ee89e2b64a9cb0f5 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat May 6 09:04:00 2017 +0200 runtests.pl: simplify the datacheck read section Also, document that numbered datacheck sections are possible. commit 6dc3422d48b002887ae3a78afdf626f792397c06 Author: Marcel Raad <raad@teamviewer.com> Date: Fri May 5 21:29:50 2017 +0200 tests: fix -Wcast-qual warnings Avoid casting string literals to non-const char *. commit 2b7bde4d3f08f1414fd73cb908d60e53949c33da Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 5 17:26:08 2017 +0200 docs/opts: 24 more man pages now have examples commit 58a6265a40bce369ba523364905489dcc6a11551 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 5 16:30:23 2017 +0200 docs/opts: 23 more man pages now have examples commit 22fdb0954c1492f88a49487ab1e4670938c74629 Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 5 15:51:25 2017 +0200 tests/server: run checksrc by default in debug-builds commit 9b47f67929d8a962def79121b585e5e4754c9e1d Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 5 13:54:32 2017 +0200 curl_slist_append.3: clarify a NULL input creates a new list commit ad8c1472fec946a9bae2d688bbadb7d77123b147 Author: Marcel Raad <raad@teamviewer.com> Date: Fri May 5 11:44:22 2017 +0200 unit1305: fix compiler warning calloc and ai_addrlen expect different (usually unsigned) types. commit 1ef38a95d27d51366ca291c332af9f35782896bf Author: Daniel Stenberg <daniel@haxx.se> Date: Fri May 5 08:12:24 2017 +0200 runtests: use -R for random order Suggested-by: Dan Fandrich commit 067b8f230460388442f9f9f5ed7a744ca9c646b5 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 4 16:32:56 2017 +0200 runtests: add -o to run test cases in scrambled order ... instead of numerical order. Closes #1466 commit 79bb0afddb4a59033b82a9a55acf317e85f57e3c Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu May 4 22:36:40 2017 +0200 sockfilt.c: shortened too long line commit 4032c5da8473fc7d55e9a96471b697c62663c194 Author: Marcel Raad <raad@teamviewer.com> Date: Thu May 4 20:19:10 2017 +0200 tests/server: make string literals const assign string literals to const char * instead of char * in order to avoid a lot of these warnings: cast from 'const char *' to 'char *' drops const qualifier [-Wcast-qual] commit 07fd7871b38cc8472c3806e254ba4062e3adeae0 Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu May 4 18:19:13 2017 +0200 schannel: return a more specific error code for SEC_E_UNTRUSTED_ROOT commit 7cb1e1ee0136b3e37b1b234342c64f2fc181a6b2 Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu May 4 18:03:03 2017 +0200 test557: set a known good numeric locale Windows does not allow setting the locale with environment variables (as the test attempted to do), so the test failed when run with a user locale that has a comma as radixchar. Changed the test to call setlocale() explicitly to ensure that a known working locale is set even on Windows. commit ff108521589639e63caa5a589bb8ee80dea1eac6 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 4 15:49:38 2017 +0200 curl: fix warning "comma at end of enumerator list" commit dfb0595a739ee89b8b01003e3c0af5cb1138ad7c Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 4 15:39:04 2017 +0200 test559: verify use of minimum CURLOPT_BUFFERSIZE commit a51ca050fc193aea9b7ace018c1588a107891d49 Author: Marcel Raad <raad@teamviewer.com> Date: Thu May 4 08:50:35 2017 +0200 curl_setup_once: use SEND_QUAL_ARG2 for swrite SEND_QUAL_ARG2 had to be set, but was never used. Use it in swrite to avoid warnings about casting away low-level const. Closes https://github.com/curl/curl/pull/1464 commit 4b933821934a176a5a0fde950c02d6b615c70c5c Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 4 00:00:13 2017 +0200 CURLINFO_REDIRECT_URL.3: add example commit b065a508c652e6ba78f8d07caa14992cfe644bb4 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu May 4 00:00:07 2017 +0200 CURLINFO_EFFECTIVE_URL.3: add example commit cee39aa3beb2da995104a2c57fe9a24be6b9f6c0 Author: Marcel Raad <raad@teamviewer.com> Date: Tue May 2 20:47:13 2017 +0200 lib: fix compiler warnings Fix the following warnings when building the tests by using the correct types: cast from 'const char *' to 'void *' drops const qualifier [-Wcast-qual] implicit conversion changes signedness [-Wsign-conversion] commit fa12f54bba39bf5795826e04c9f0fa1a4e052157 Author: Marcel Raad <raad@teamviewer.com> Date: Wed Apr 26 20:14:51 2017 +0200 typecheck-gcc: add support for CURLINFO_SOCKET Closes https://github.com/curl/curl/pull/1452 commit 3ff0d2fb00c33c70deb937df6e4be28eb5e81498 Author: Marcel Raad <raad@teamviewer.com> Date: Wed Apr 26 19:56:24 2017 +0200 typecheck-gcc: add missing string options Closes https://github.com/curl/curl/pull/1452 commit 1bfdbb5a5141a88aa5900786407cb24aceca09d7 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed May 3 14:22:58 2017 +0200 abstract-unix-socket.d: shorten the help text to fit within 79 cols commit 120488d9d63ccae19baf733a2cd2e79063a47a8d Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 2 23:41:21 2017 +0200 RELEASE-NOTES: synced with 862b02f89 commit 862b02f8947039e9a7f5d6ae47b547e3bf295988 Author: Richard Hsu <richardhsu.cs@gmail.com> Date: Tue Apr 4 19:26:29 2017 -0700 Telnet: Write full buffer instead of byte-by-byte Previous TODO wanting to write in chunks. We should support writing more at once since some TELNET servers may respond immediately upon first byte written such as WHOIS servers. Closes #1389 commit 913c3c8f5476bd7bc4d8d00509396bd4b525b8fc Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 1 01:23:53 2017 +0200 curl: non-boolean command line args reject --no- prefixes ... and instead properly respond with an error message to the user instead of silently ignoring. Fixes #1453 Closes #1458 commit f2d5d05893880bea6ae5951020ab47b7c581f8ec Author: Marcel Raad <raad@teamviewer.com> Date: Tue May 2 21:09:41 2017 +0200 testpart: remove _MPRINTF_REPLACE Support for _MPRINTF_REPLACE in mprintf.h was removed in 55452ebdff47f98bf3cc383f1dfc3623fcaefefd, replaced with curl_printf.h. commit 6943085b50429b873e26998b2ced0f6ecc58ed56 Author: Dan Fandrich <dan@coneharvesters.com> Date: Tue May 2 09:08:56 2017 +0200 gtls: fixed a lingering BUFSIZE reference commit eab6732fde094073480af5039b6fb495cbc3fb8a Author: Daniel Stenberg <daniel@haxx.se> Date: Tue May 2 08:32:04 2017 +0200 ssh: fix compiler warning from e40e9d7f0de commit 4858c451ee54d0104f68408debb3a32947b7b273 Author: Daniel Stenberg <daniel@haxx.se> Date: Mon May 1 00:31:56 2017 +0200 url: let CURLOPT_BUFFERSIZE realloc to smaller sizes too Closes #1449 commit e3ed5cb380e615e91d99b09da9f0ead0eaf3e0b5 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 15:31:14 2017 +0200 BUFSIZE: rename to READBUFFER_*, make separate MASTERBUF_SIZE commit 799c7048dc9d5b4e4af50a4f36867742578c7663 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 15:28:50 2017 +0200 openssl: use local stack for temp storage commit 7ee52c25f35816968b86d32eaef70ab743a457d4 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 15:19:19 2017 +0200 sendf: remove use of BUFSIZE from debug data conversions The buffer can have other sizes. commit e40e9d7f0decc799e3ccfe2c418632f8bb52031a Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 14:38:34 2017 +0200 buffer: use data->set.buffer_size instead of BUFSIZE ... to properly use the dynamically set buffer size! commit c79f4908d461cecaa9976099dcbb8a63b351f19e Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 14:37:45 2017 +0200 krb5: use private buffer for temp string, not receive buffer commit 89cf6f38d2f525cbc8537a60061f5f37bb2f35f7 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 14:37:06 2017 +0200 upload: UPLOAD_BUFSIZE is now for the upload buffer commit 8ed81f67c2a3783c04e52b16d39bf998bd998c06 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 08:46:18 2017 +0200 unit1606: do not print/access buffer It was a wrong assumption that it could do that! commit 0cab3a394a190c1cdf900cf2887ccdd6a7f213ef Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 01:03:17 2017 +0200 http-proxy: use a dedicated CONNECT response buffer To make it suitably independent of the receive buffer and its flexible size. commit 40a074f255de90003ab753f5d0ad61b74c62ca9b Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:50:50 2017 +0200 transfer: fix minor buffer_size mistake commit f2fadf490f66ad364f5a6f0356d626dda5f9a82f Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:50:21 2017 +0200 failf: use private buffer, don't clobber receive buffer commit b8191e975faa7810ed3d858205b0b3f0d297f0b2 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:50:04 2017 +0200 pingpong: use the set buffer size commit 504eafff865478827f04f31e45ac367672f3e18d Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:49:23 2017 +0200 http2: use the correct set buffer size commit 87eb8d5b30ce2adfe2673cc0b1abf6ca68891cc4 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:48:56 2017 +0200 http: don't clobber the receive buffer for timecond commit f535f4f5fc6cbdce1aec5a3481cec37369dca468 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:16:10 2017 +0200 buffer_size: make sure it always has the correct size Removes the need for CURL_BUFSIZE commit 7c312f84ea930d89c0f0f774b50032c4f9ae30e4 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:15:28 2017 +0200 file: use private buffer for C-L output ... instead of clobbering the download buffer. commit c2ddc12d6086b522703c8b80a72ab791680f1a28 Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 00:09:22 2017 +0200 CURLOPT_BUFFERSIZE: 1024 bytes is now the minimum size The buffer is needed to receive FTP, HTTP CONNECT responses etc so already at this size things risk breaking and smaller is certainly not wise. commit 349789e645a306a6ee467ef90a57f6cc306ca92e Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Apr 24 16:05:46 2017 +0200 ftp: use private buffer for temp storage, not receive buffer commit 94460878cc634b590a7282e3fe60ceafb62d141a Author: Daniel Stenberg <daniel@haxx.se> Date: Mon Apr 24 15:33:57 2017 +0200 http: use private user:password output buffer Don't clobber the receive buffer. commit 35311b22b92475a3a0ac65b13e0fce6ed85b060b Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 1 21:51:02 2017 +0200 anyauthput: remove unused code The definition of TRUE was introduced in 4a728747e6f8845e500910e397dfc99aaf4a7984 and is not used anymore since e664cd5826d43930fcc5b5dbaedbec94af33184b. The usage of intptr_t was removed in 32e38b8f42477cf5ce3c3fef2fcc9db82f7fb7be. commit 5b13619da4d12f262a289a8b93eedec00e977a60 Author: Jay Satiro <raysatiro@yahoo.com> Date: Mon May 1 14:10:43 2017 -0400 tool: Fix missing prototype warnings for CURL_DOES_CONVERSIONS - Include tool_convert.h where needed. Bug: https://github.com/curl/curl/issues/1460 Reported-by: Gisle Vanem commit 499a7288fe831ef51a9b0930fc67bcd97aa6c675 Author: Jay Satiro <raysatiro@yahoo.com> Date: Mon May 1 13:44:39 2017 -0400 curl_setup: Ensure no more than one IDN lib is enabled Prior to this change it was possible for libcurl to be built with both Windows' native IDN lib (normaliz) and libidn2 enabled. It appears that doesn't offer any benefit --and could cause a bug-- since libcurl's IDN handling is written to use either one but not both. Bug: https://github.com/curl/curl/issues/1441#issuecomment-297689856 Reported-by: Gisle Vanem commit 0912a5c760dd9b85692e121313a04797b52d4ab2 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 1 13:17:57 2017 +0200 getpart: use correct variable type This fixes the following clang warning: getpart.c:201:17: warning: cast from function call of type 'CURLcode' to non-matching type 'int' [-Wbad-function-cast] commit 7dd89c1cdcda16945610c4cdef89b5cdb2c183a8 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 1 12:55:09 2017 +0200 tests: declare TU-local variables static This fixes missing-variable-declarations warnings when building with clang. commit c3513f7e83804d63f3ba8e65d34ada38974d7851 Author: Marcel Raad <raad@teamviewer.com> Date: Mon May 1 11:46:44 2017 +0200 tool_cb_prg: fix double-promotion warning clang complains: tool_cb_prg.c:86:22: error: implicit conversion increases floating-point precision: 'float' to 'double' [-Werror,-Wdouble-promotion] Fix this by using a double instead of a float constant. commit 6cba8dacea773ab37ae457e2a2d24d2ead9f68a4 Author: Dan Fandrich <dan@coneharvesters.com> Date: Mon May 1 09:16:12 2017 +0200 examples: fixed too long line and too long string warnings commit c23177d5e90aec2ec42bd20004d0acf0a6412456 Author: Marcel Raad <raad@teamviewer.com> Date: Sun Apr 30 23:29:31 2017 +0200 examples: declare TU-local variables static This fixes missing-variable-declarations warnings when building with clang. commit dc9e4859bb50e4d438dbbb016870effea395b624 Author: Marcel Raad <raad@teamviewer.com> Date: Sun Apr 30 22:33:33 2017 +0200 http2: declare TU-local variables static This fixes the following clang warnings: http2.c:184:27: error: no previous extern declaration for non-static variable 'Curl_handler_http2' [-Werror,-Wmissing-variable-declarations] http2.c:204:27: error: no previous extern declaration for non-static variable 'Curl_handler_http2_ssl' [-Werror,-Wmissing-variable-declarations] commit 092d012441e92f3dfca2a6e923c36edb8ab60e96 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun Apr 30 15:21:54 2017 +0200 unit1604: fixed indentation commit c0a27c5cee3c437de1629eae53d0a2c2f750488d Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun Apr 30 13:35:17 2017 +0200 unit1604: fixed compilation under Windows, broken in the previous commit commit 8089dcfc5d4b34b15cee1f1cc9b3124c0279d41b Author: Dan Fandrich <dan@coneharvesters.com> Date: Sun Apr 30 10:54:26 2017 +0200 tests: fixed OOM handling of unit tests to abort test It's dangerous to continue to run the test when a memory alloc fails. commit 65c6caacaee87f2b09aa03e5eed1bcbd9e356f68 Author: Marcel Raad <raad@teamviewer.com> Date: Sat Apr 29 19:17:51 2017 +0200 curl_rtmp: fix missing-variable-declarations warnings clang complains: curl_rtmp.c:61:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmp' [-Werror,-Wmissing-variable-declarations] curl_rtmp.c:81:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmpt' [-Werror,-Wmissing-variable-declarations] curl_rtmp.c:101:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmpe' [-Werror,-Wmissing-variable-declarations] curl_rtmp.c:121:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmpte' [-Werror,-Wmissing-variable-declarations] curl_rtmp.c:141:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmps' [-Werror,-Wmissing-variable-declarations] curl_rtmp.c:161:27: error: no previous extern declaration for non-static variable 'Curl_handler_rtmpts' [-Werror,-Wmissing-variable-declarations] Fix this by including the header file. commit 12e7a8c3d609d6a6094a7db8fb8c0cc80d8f55f0 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat Apr 29 18:52:51 2017 +0200 url: fixed a memory leak on OOM while setting CURLOPT_BUFFERSIZE commit 584142892f7d5fb3100f3c0ef8e479d472b8c3c7 Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat Apr 29 10:16:06 2017 +0200 tests: added --remote-time tests for remaining protocols that support it commit 2ce86d8509fa49d371af60d26bd934f90b99aeff Author: Dan Fandrich <dan@coneharvesters.com> Date: Sat Apr 29 10:00:15 2017 +0200 runtests.pl: support multiline <postcheck> commands commit 4da846a41ed19f2a81357d30cf210bf4616a8798 Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu Apr 27 01:24:07 2017 +0200 tool_operate: use utimes instead of obsolescent utime when available commit 3364de00f75ef1bc9d2e70a74e63090d583e048d Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu Apr 27 22:29:06 2017 +0200 test1443: test --remote-time commit 63503a969fe9e11907f7e3f262a3f6c27d885f60 Author: Dan Fandrich <dan@coneharvesters.com> Date: Thu Apr 27 11:42:04 2017 +0200 http-proxy: removed unused argument in CURL_DISABLE_PROXY case Missed in commit 55c3c02e commit 7543f28ad2fb65e6aef9f00c64b71749f087401a Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Apr 27 00:30:34 2017 +0200 cookie_interface.c: changed the other domain to example.com too commit afe05ee2eebeea574aa5cc3fd62e5ede3d821342 Author: Daniel Stenberg <daniel@haxx.se> Date: Thu Apr 27 00:27:59 2017 +0200 cookie_interface.c: fix cookie domain so the example works commit 8b03436d3cc7b8b0359b5a658c38fe52484dcd61 Author: Dan Fandrich <dan@coneharvesters.com> Date: Wed Apr 26 23:02:42 2017 +0200 Makefile: fix make dist Commit 80a87e8a broke 'make dist' as it can't handle installing from absolute target names. Rearranged the dependencies so the absolute name is used for building but the relative name is use for distributing. commit b85142164228abe15d6ca20a244ffb849c700e6c Author: Marcel Raad <raad@teamviewer.com> Date: Tue Apr 25 08:36:13 2017 +0200 lib: remove unused code This fixes the following clang warnings: macro is not used [-Wunused-macros] will never be executed [-Wunreachable-code] Closes https://github.com/curl/curl/pull/1448 commit 55c3c02e59d1daf31ec2097f93b8139ddb3fdeb6 Author: Daniel Stenberg <daniel@haxx.se> Date: Wed Apr 26 00:34:22 2017 +0200 http-proxy: remove unused argument from Curl_proxyCONNECT() commit fb67c977b98d8a7e1fcbed523fe6ce0c06ec1ac8 Author: Martin Kepplinger <martink@posteo.de> Date: Tue Apr 25 23:55:57 2017 +0200 url: declare get_protocol_family() static get_protocol_family() is not defined static even though there is a static local forward declaration. Let's simply make the definition match it's declaration. Bug: https://curl.haxx.se/mail/lib-2017-04/0127.html commit e7f8ac19458ba92da78a8a24043922141cc68d4a Author: Daniel Stenberg <daniel@haxx.se> Date: Tue Apr 25 15:58:51 2017 +0200 examples: ftpuploadfrommem.c Uploads data to an FTP site, directly from memory. Closes #1451 commit e3e8d0204b72509cfd63d97a159d1ac3fdea703b Author: Kamil Dudka <kdudka@redhat.com> Date: Mon Apr 10 17:40:30 2017 +0200 nss: load libnssckbi.so if no other trust is specified The module contains a more comprehensive set of trust information than supported by nss-pem, because libnssckbi.so also includes information about distrusted certificates. Reviewed-by: Kai Engert Closes #1414 commit fab3d1ec650e17fd15cf8b6d4ffa5bfd523501dc Author: Kamil Dudka <kdudka@redhat.com> Date: Mon Apr 10 17:05:05 2017 +0200 nss: factorize out nss_{un,}load_module to separate fncs No change of behavior is intended by this commit. commit c8ea86f377a2f341db635ec96f99314023b5a8f3 Author: Kamil Dudka <kdudka@redhat.com> Date: Mon Apr 24 15:01:04 2017 +0200 nss: do not leak PKCS #11 slot while loading a key It could prevent nss-pem from being unloaded later on. Bug: https://bugzilla.redhat.com/1444860 commit 9c5aed185209838b524251886238da9b3d58382b Author: Marcel Raad <raad@teamviewer.com> Date: Mon Apr 24 17:56:19 2017 +0200 typecheck-gcc: fix _curl_is_slist_info Info values starting with CURLINFO_SOCKET expect a curl_socket_t, not a curl_slist argument. This fixes the following GCC warning when building the examples with --enable-optimize: ../../include/curl/typecheck-gcc.h:126:42: warning: call to ‘_curl_easy_getinfo_err_curl_slist’ declared with attribute warning: curl_easy_getinfo expects a pointer to 'struct curl_slist *' for this info [enabled by default] sendrecv.c:90:11: note: in expansion of macro ‘curl_easy_getinfo’ res = curl_easy_getinfo(curl, CURLINFO_ACTIVESOCKET, &sockfd); Closes https://github.com/curl/curl/pull/1447 commit …
I would like to get the TLS certificate chain using
curl_easy_getinfo(CURL *, CURLINFO_CERTINFO, ...)
. I initially did this by passing astruct curl_certinfo *
, eg:I did this based on the guidance in the documentation for
CURLINFO_CERTINFO
:And indeed this seems to work nicely, however when compiling with GCC, I get the following warning:
Since there is some handy type checking on that function. This type checking disagrees with the aforementioned documentation, but agrees with the documentation for
curl_easy_getinfo
.In addition, the
certinfo.c
example throws them both into a union and uses them both.I realize that since you're really getting a pointer to a
struct curl_certinfo
, and that has astruct curl_slist *
as its first member that you can fundamentally use either. But it would be nice if the documentation and examples were internally consistent. Ideally either:curl_easy_getinfo
was updated to reflect thatstruct curl_certinfo
was a legitimate type and that the header was also updated to reflect this, orCURLINFO_CERTINFO
was updated to document thatstruct curl_slist *
is the used type.And that the aforementioned example was updated to only make reference to whichever type is canonical.
The text was updated successfully, but these errors were encountered: