-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path fixes for running tests om Cygwin/MinGW #675
Conversation
By analyzing the blame information on this pull request, we identified @mback2k, @yangtse and @dfandrich to be potential reviewers |
The truth is opposite. Currently path is hardcoded in testsuite as testsuite depends on that any Msys path must starts with "/cygdrive".
Moreover, for example, I mount my development directory as |
I can confirm msys2 /cygdrive/ paths don't work but I can also confirm original mingw32 (mine at least) doesn't come with a cygpath utility. We probably could use a function to transform the path depending on what's available. |
@jay, confirming, there are old Msys/MinGW without cygpath. |
$capath =~ s/^(\/cygdrive)?\/(\w)\//$2\:\//; | ||
$certfile =~ s/^(\/cygdrive)?\/(\w)\//$2\:\//; | ||
chomp($capath = `cygpath -m -a $capath`); | ||
chomp($certfile = `cygpath -m -a $certfile`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these do not need to be changed, because this a conversion from Cygwin and msys to Windows style paths. The cygdrive part is actually optional here.
Closing with 20 days with no comments to the review remarks. Feel free to re-open when/if we come back to this work again. |
It's not abandoned. I had to learn Perl to write module which is flexible enough to handle all Msys/Cygwin configurations. Will publish it soon, but I can't reopen this PR - only repo owners can do this. |
Well, if it is a different fix then it could warrant a new separate pull request. But sure, I'll reopen this if you think it is better. |
@Karlson2k I'm curious about the test on |
@gvanem, Strawberry Perl as well as ActivePerl have |
Thanks. Just what I thought. |
8903dc5
to
c31d985
Compare
Updated with new Perl helper module. |
c31d985
to
49cf003
Compare
Updated with improved compatibility with older Perl. |
thanks! |
This PR fix path conversion in testsuite for Cygwin/Msys.
Cygwin allow to map drives to some custom paths, so
C:\\Windows\
can be mapped not to/cygdrive/c/Windows
. Moreover, Msys2 use simplified scheme/c/Windows
by default.