-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md4: use init/update/final functions in Secure Transport #4979
Conversation
It looks good Nick, My only question is
whilst we use |
Before you send this upstream please make sure to rebase on upstream/master (ie no merge commits) and then amend the commit message to add a separate section with a reference to the PR and any issues it solves, for example
If you need a refresher please refer to push-access-guidelines |
@captain-caveman2k, I'll add that preprocessor macro, though I'll be very surprised if anyone still targets macOS 10.3 or earlier anymore, since it's almost 17 years old at this point. @jay, I'll edit that. Is it okay if I use the "rebase & merge" button on Github, or does that do something undesired? You can tell I don't do this often... |
Unfortunately no, this is covered in the guidelines, as far as I know the only way to get the correct attribution (ie committer remains committer) is by pushing from the command line. In this case that would look like:
I'm assuming you use the name upstream for curl/curl, for example
|
Do we still need the The main reason for asking is |
Actually, no, we really don't. It can run on macOS and iOS independently of the Security framework. |
We can use CC_MD4_Init/Update/Final without having to allocate memory directly. Closes #4979
Okay, I'm still trying to merge this from the command line, and I'm not having much luck. Here's what I'm doing:
I can type |
That's weird and I don't know what that is. You have write access and 2FA enabled so there should not be anything stopping you. Try git remote -v see what it shows, also try GIT_TRACE=1 git ...
Not as far as I know. The ssh key should be the ssh key in the settings on your account. Sometimes github has intermittent issues. |
I'll try again later, but everything looks correct to me...
|
I pushed it! |
No description provided.