cmake: bring curl-config.cmake closer to FindCURL
#13897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with CMake's `FindCURL.cmake`. Reported-by: Aurélien Pierre Ref: https://curl.se/mail/lib-2024-06/0007.html Closes #xxxxx
This comment was marked as duplicate.
This comment was marked as duplicate.
7 tasks
CURL_LIBRARIES in curl-config.cmakecurl-config.cmake closer to FindCURL
curl-config.cmake closer to FindCURLcurl-config.cmake closer to FindCURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
CURL_LIBRARIESandCURL_INCLUDE_DIRSvariablesfor compatibility with CMake's
FindCURL.cmake:https://github.com/Kitware/CMake/blob/b411d0146c2e06acfb0c823bb039e99f0191b611/Modules/FindCURL.cmake#L209
For dependent projects, CMake's suggestion is to replace
CURL_LIBRARIESwithCURL::libcurl, and dropCURL_INCLUDE_DIRS.Reported-by: Aurélien Pierre
Ref: https://curl.se/mail/lib-2024-06/0014.html
Ref: https://gitlab.kitware.com/cmake/cmake/-/issues/24580
Closes #13897
/cc @aurelienpierre Do you think this would help with this issue?
Ref: aurelienpierreeng/ansel#334