commit | 58aa7b0a938464dc548e1f5e1a04e154f15d2375 | [log] [tgz] |
---|---|---|
author | Julia Hansbrough <flowerhack@google.com> | Tue Jan 17 21:08:41 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 17 21:08:41 2023 |
tree | a7536e2d8cb9e25d8a952d386193c527e0989b0f | |
parent | 91bc334736ff35da1329f4e1b50861f23702ca74 [diff] |
[coverage] Perform glob expansion so that the coverage script works on fuzz targets. The `coverage.py` file has instructions for how to generate coverage for fuzz targets. However, the command as-written fails because StandaloneFuzzTarget expects to receive a list of inputs; it exits with an error if it's given a pointer to a directory. It's simple enough to simply append `/*` to the directory, but Python's subprocess doesn't support glob expansion. So, this commit (1) changes the instructions to the new command, and (2) enables glob expansion on that command. Bug: 1356583 Change-Id: I90345b05d5baf4d016551f5d2f39ec18a8535277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121294 Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Julia Hansbrough <flowerhack@google.com> Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Jeff Yoon <jeffyoon@google.com> Cr-Commit-Position: refs/heads/main@{#1093525}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.