[go: up one dir, main page]
Closed Bug 1985552 Opened 3 months ago Closed 2 months ago

The destination of the request for a top-level navigation should be set to "document"

Categories

(Remote Protocol :: WebDriver BiDi, defect, P3)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
2

Tracking

(firefox145 fixed)

Status:
RESOLVED FIXED
Milestone:
145 Branch
Tracking Flags:
Tracking Status
firefox145 --- fixed

People

(Reporter: hbenl, Assigned: jdescottes)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m17][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 1985552 - [bidi] Set destination to 'document' for top-level navigation requests
48 bytes, text/x-phabricator-request
Details | Review
Bug 1985552 - [wdspec] Update wdspec tests for destination of top-level navigation requests
48 bytes, text/x-phabricator-request
Details | Review

When I look at the request in a network.beforeRequestSent event for a top-level navigation, destination is set to "" but it should be "document" according to this table.

See Also: → 1904892

Oh indeed I misunderstood the HTML spec in https://bugzilla.mozilla.org/show_bug.cgi?id=1933250#c0 .
The request for a navigation is created at https://html.spec.whatwg.org/multipage/browsing-the-web.html#create-navigation-params-by-fetching with a "document" destination. I remember having a hard time with that because destination and initiator are referenced in several specs and some of them were outdated.

In any case I agree that we should fix this to be "document"

Blocks: 1933250

FWIW, Chrome's BiDi implementation also sets destination to "" for top-level navigations.

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(hskupin)
Severity: -- → S3
Points: --- → 2
Priority: -- → P3
Whiteboard: [webdriver:m17]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/79841af3ad78 https://hg.mozilla.org/integration/autoland/rev/c6055864e333 [bidi] Set destination to 'document' for top-level navigation requests r=webdriver-reviewers,whimboo https://github.com/mozilla-firefox/firefox/commit/6cafd0d0be4c https://hg.mozilla.org/integration/autoland/rev/c0c1301d5efc [wdspec] Update wdspec tests for destination of top-level navigation requests r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55061 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m17] → [webdriver:m17], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/c6055864e333
https://hg.mozilla.org/mozilla-central/rev/c0c1301d5efc

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox145: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(hskupin)
Whiteboard: [webdriver:m17], [wptsync upstream] → [webdriver:m17][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: