This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fix SelectionState’s hasEdgeWithin
#1811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewbranch - thanks for putting up this fix. I won't get a chance to review until next weekend, but if you could rebase on master in the meanwhile, that would be a big help! |
|
@niveditc done 👍 |
niveditc
approved these changes
Oct 7, 2018
|
Next steps are that:
|
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: Fixes facebookarchive#1700, which includes a detailed description and reproduction of the issue. Hopefully it's ok that I refactored the true/false assertions not to use snapshots; I found them confusing and tedious and figured it was probably just an artifact of migrating to Jest a long time ago. Pull Request resolved: facebookarchive#1811 Differential Revision: D10234643 fbshipit-source-id: 531e45c8fe1708fb440240e1a7bd121cb126cd08
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Fixes #1700, which includes a detailed description and reproduction of the issue. Hopefully it's ok that I refactored the true/false assertions not to use snapshots; I found them confusing and tedious and figured it was probably just an artifact of migrating to Jest a long time ago. Pull Request resolved: facebookarchive/draft-js#1811 Differential Revision: D10234643 fbshipit-source-id: 531e45c8fe1708fb440240e1a7bd121cb126cd08
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Fixes #1700, which includes a detailed description and reproduction of the issue. Hopefully it's ok that I refactored the true/false assertions not to use snapshots; I found them confusing and tedious and figured it was probably just an artifact of migrating to Jest a long time ago. Pull Request resolved: facebookarchive/draft-js#1811 Differential Revision: D10234643 fbshipit-source-id: 531e45c8fe1708fb440240e1a7bd121cb126cd08
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1700, which includes a detailed description and reproduction of the issue.
Hopefully it's ok that I refactored the true/false assertions not to use snapshots; I found them confusing and tedious and figured it was probably just an artifact of migrating to Jest a long time ago.