[go: up one dir, main page]
Bug 195577 - devel/jsoncpp: pass whole environment through SCons
Summary: devel/jsoncpp: pass whole environment through SCons
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-02 04:05 UTC by Dmitry Marakasov
Modified: 2014-12-02 14:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (johan)

Attachments
Proposed patch (1.04 KB, patch)
2014-12-02 04:05 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-02 04:05:57 UTC 
Created attachment 150093 [details]
Proposed patch

By default, SCons cleans environment it passes to child processes. This breaks build in certain cases - for example, when ccache is used and CCACHE_DIR is passed to set its cache directory (that is used by poudriere, for instance).
Though upstream SConstruct passes some variables, this is not enough, so pass everything.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-02 04:05:57 UTC 
Maintainer CC'd
Comment 2 Johan Ström 2014-12-02 08:36:08 UTC 
I'm not too familiar with scons (haven't used it more than using it in this port), but I don't see any apparent problem, as long as it builds fine.

Go ahead!
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-02 14:26:16 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Dec  2 14:26:00 UTC 2014
New revision: 373763
URL: https://svnweb.freebsd.org/changeset/ports/373763

Log:
  - Prevent SCons from trimming environment

  PR:		195577
  Submitted by:	amdmi3
  Approved by:	johan@stromnet.se (maintainer)

Changes:
  head/devel/jsoncpp/files/patch-SConstruct